Trevor Parscal
02e24d6a39
Merge "Bugzilla:37804 - Double bound events were causing double backspace bugs"
2012-06-27 16:20:43 +00:00
Christian Williams
89e0f3d6ad
Bugzilla:37804 - Double bound events were causing double backspace bugs
...
Change-Id: I589185d077e1efe6fb2c0457a290a8ac9ce8bceb
2012-06-22 15:39:43 -07:00
Christian Williams
122a31a021
Bugzilla:33093 - Shift-Enter splits at paragraphs instead of list items
...
Change-Id: Ie32e878cf9c71f7179143c631a01c0e2e671ed18
2012-06-22 15:05:35 -07:00
Trevor Parscal
1ea3999e04
Fixed drop-down menu to match items more carefully
...
Change-Id: Ibd46861be243d2872f4edaa9a182d3931d4f9fab
2012-06-21 17:50:46 -07:00
Trevor Parscal
7af5af7683
Merge "Adjust oldRange in the rebuildNodes call as well"
2012-06-22 00:43:29 +00:00
Trevor Parscal
5af7c4d833
Merge "When trying to turn list items into headings, unlist them"
2012-06-22 00:42:51 +00:00
Catrope
fb38655ff0
When trying to turn list items into headings, unlist them
...
This requires splitting the list and unwrapping the items
Change-Id: Ie77fe00d2396e4f7d2f1b28bfc0b0301255454a4
2012-06-21 17:41:58 -07:00
Catrope
62b78c9109
Adjust oldRange in the rebuildNodes call as well
...
This fixes a bug Trevor reported where selecting from a list item across
a heading and into a paragraph, pressing backspace, then clicking undo
caused an exception.
Change-Id: Id2851271529e10548f6979a030a198054aa1c48f
2012-06-21 17:26:17 -07:00
Catrope
a0d87989cf
You know what, just don't render hrefs, these links aren't clickable anyway
...
Change-Id: If5f0c9a2fa41f09569195fe7807aba9a8207a3c9
2012-06-21 16:12:17 -07:00
Trevor Parscal
b560924467
Merge "Use title for rendering internal links, and guard against undefined"
2012-06-21 23:04:11 +00:00
Catrope
6ddfc4bcab
Use title for rendering internal links, and guard against undefined
...
Change-Id: I18a4e5e06303fcd9540fde8c3b21fe8f8887417e
2012-06-21 15:52:25 -07:00
Trevor Parscal
f021b02ce1
Merge "Reconcile the order and completeness of textStyles in 2 different places"
2012-06-21 22:33:41 +00:00
Catrope
9576f8fc48
Escape the href attribute on links
...
Change-Id: I3edaa5c9346f5c8c222c482bcb190acad2bac24d
2012-06-21 15:28:07 -07:00
Christian Williams
4f43ecefdf
No need to apply selection in this transaction
...
Change-Id: Ia1ea5800dfbe5d89ef2fe22462712d8a558e5e3b
2012-06-21 15:20:21 -07:00
Inez Korczynski
41f5f7378b
In Firefox hitting enter fires both events - keydown and keypress. We want to ignore key press for enter.
...
Change-Id: I49d19267cc6115342aadf11ea720e82bbf65ddb2
2012-06-21 14:52:43 -07:00
Catrope
f58b5b6fc8
Reconcile the order and completeness of textStyles in 2 different places
...
ve.ce.TextNode listed textStyle annotations that didn't actually exist,
and failed to recognize some that did exist (such as span; bug 37808).
Added all annotations to both places. <span> tags are now tolerated by
the editor in that it doesn't crash anymore, but they're displayed (and
saved!) without any attributes, so <span style="color:yellow;">y</span>
doesn't show a yellow 'y' in the editor and is saved back as
<span>y</span> .
Change-Id: Iaae11ad5044150fa904010983ff83579cb37733d
2012-06-21 14:46:43 -07:00
Trevor Parscal
ed33ca373f
Merge "Undo and redo keyboard shortcuts"
2012-06-21 20:58:53 +00:00
Christian Williams
050134d55e
Undo and redo keyboard shortcuts
...
Change-Id: Ia1e9db52f6fb2da79be28cdedaaf0dffc6097dc9
2012-06-21 13:58:21 -07:00
Inez Korczynski
07760653b2
Don't use custom handling for left and right arrow while metaKey is pressed as well.
...
Change-Id: I7e2f73ab085b877169f4a29bec04a294d6e13a2a
2012-06-21 13:56:32 -07:00
Trevor Parscal
d245ac030e
Merge "Fix display of edit summary message in save dialog"
2012-06-21 20:44:28 +00:00
Catrope
ae48f152f9
Fix display of edit summary message in save dialog
...
Fixed by adding the specialMessages module which is only loaded once the
editor loads. Then after it's loaded we use the summary message from
there to update the (possibly broken) summary message in the save
dialog.
Change-Id: I67f5c59501cdf7c66c925cef8d4dd42b0f2cfde3
2012-06-21 13:39:27 -07:00
Inez Korczynski
6381709703
In case of IE use non-breaking spaces inside slugs instead of invisible separators - as in different browsers.
...
Change-Id: Ib6ae077206de1ad772e47e212a9f276f6b0081e0
2012-06-21 13:34:13 -07:00
Rob Moen
3f8863b05a
If siteNotice is visible, add class and slide it up. On ve exit,
...
SlideDown fast if hidden by ve
Change-Id: I2a4104590de15da1302181a68d38bf271bcca249
2012-06-21 13:01:42 -07:00
Trevor Parscal
d4e51abac6
Merge "Tear down the beforeUnload handler when redirecting after page creation"
2012-06-21 19:48:51 +00:00
Trevor Parscal
51809e728b
Merge "Fix external link inspector"
2012-06-21 19:48:06 +00:00
Catrope
3a704b7491
Merge "Create init methods which hide and restore siteNotice if present."
2012-06-21 19:46:17 +00:00
Rob Moen
f28a2399f4
Create init methods which hide and restore siteNotice if present.
...
Change-Id: I2fbc74ae46474cdb2559ecaa083cc7353b050937
2012-06-21 12:44:33 -07:00
Catrope
fba013bedf
Tear down the beforeUnload handler when redirecting after page creation
...
Change-Id: If182eb62068c3c585a98535cc6761d98ad7dd56d
2012-06-21 12:41:39 -07:00
Catrope
5784d2b55c
Fix external link inspector
...
Wasn't loading the link target due to a typo
Change-Id: I77533f949363e79dab9b478e6ba10d05b9486acc
2012-06-21 12:40:28 -07:00
Trevor Parscal
437649e062
Merge "Fix problem in hasSlugAtOffset when a given offset is out of range of the document - so no node is returned from getNodeAtOffset"
2012-06-21 18:19:51 +00:00
Inez Korczynski
82d3040d76
Fix problem in hasSlugAtOffset when a given offset is out of range of the document - so no node is returned from getNodeAtOffset
...
Change-Id: I91951528c21ddd57f56d7f4854d0e626d96e04a1
2012-06-21 11:09:41 -07:00
Trevor Parscal
f35c8adac8
Merge "Aggressive keyboard shortcut fix for all browsers and platforms"
2012-06-21 18:09:24 +00:00
Christian Williams
8f7ce742de
Aggressive keyboard shortcut fix for all browsers and platforms
...
Change-Id: Ic9e6359a06752861a05526dba090b08ccd39b83f
2012-06-21 11:09:30 -07:00
Inez Korczynski
847fddd639
Fix for drawing selection in IE - temporary approach
...
Change-Id: Ia944e4c96b1d1d78274f9c23e7120954f694ca08
2012-06-21 11:04:26 -07:00
Trevor Parscal
fc7e96b2b5
Merge "Rename watch to watchpage, per https://gerrit.wikimedia.org/r/12423 "
2012-06-21 17:52:25 +00:00
Catrope
ff39a448a3
Merge "Fixed output of translateOffset when collapsing a range"
2012-06-21 17:48:43 +00:00
Catrope
a904bcc0f3
Rename watch to watchpage, per https://gerrit.wikimedia.org/r/12423
...
Change-Id: Ic38ea27ead9f98b22b1fbbad5dcbb8de2205f51a
2012-06-21 10:46:47 -07:00
Trevor Parscal
5aa3bbedc7
Fixed output of translateOffset when collapsing a range
...
Change-Id: Ifb40dd1f9de557d4237660f5fb7119d6aa940c65
2012-06-21 10:45:58 -07:00
Christian Williams
f27425eb91
Firefox has some crazy bindings for browser features. This prevents it and properly annotates.
...
Change-Id: Ide294efda8b661e16f24cc1f3584a8f08785ff5b
2012-06-21 10:33:40 -07:00
Trevor Parscal
861ce8d54f
Fixed pressing backspace in a slug, now we just move the cursor to some nearby content
...
Change-Id: Idaf61264fb493169cfef1c48613036c292d590f0
2012-06-21 00:01:32 -07:00
Trevor Parscal
c548b3cdba
Merge changes I44515c86,Ife902ace,Ia6510de1
...
* changes:
Got rid of iteration to get the surface
Removed attach and detach methods from ve.ce.Node
Track adjustments in DocumentSynchronizer and apply them to oldRange
2012-06-21 06:41:57 +00:00
Trevor Parscal
07eb2df53a
Got rid of iteration to get the surface
...
Also added a safety check to make it easier to spot a regression
Change-Id: I44515c867852f2f726be74161f6b8e466c0933da
2012-06-20 23:40:38 -07:00
Trevor Parscal
00c555ebe5
Removed attach and detach methods from ve.ce.Node
...
Added some needed functionality in ve.Node to make up for this
Change-Id: Ife902aceb4e8535411dc653ae61087aecf67a0c6
2012-06-20 23:40:38 -07:00
Catrope
dc646ff32c
Track adjustments in DocumentSynchronizer and apply them to oldRange
...
This is needed because oldRange is relative to the state of the model before any changes were made, but when we call selectNodes() it's gonna operate on a partially updated model tree.
This is a genuine bug in DocumentSynchronizer proper, which means I owe the entire team lunch
Change-Id: Ia6510de19df02e961c7f25fb8e7833abceb8d25b
2012-06-20 23:40:38 -07:00
Trevor Parscal
cb3eba185d
Merge "Fix adjustment of newRange in TransactionProcessor"
2012-06-21 06:38:42 +00:00
Catrope
df4e5f0200
Merge "Fix minor bug with space replacement in TextNode"
2012-06-21 06:37:56 +00:00
Catrope
0b9934b2cc
Fix adjustment of newRange in TransactionProcessor
...
* Adjust both start and end for preceding operations
* Adjust end for the current operation as well
Change-Id: I2f96d609bddf3788aa5700ad1f0b46208f3517d7
2012-06-20 23:37:55 -07:00
Inez Korczynski
74440be132
Fix minor bug with space replacement in TextNode
...
Change-Id: Iafdc59d9fd8654444079e55a2ad36a40cc21fa4c
2012-06-20 23:33:22 -07:00
Inez Korczynski
ab16987ae8
Better support for left & right arrow keys
...
Change-Id: Iad56f8179d3ed90828e31ad0203a5cec9e9d2458
2012-06-20 23:06:47 -07:00
Trevor Parscal
3008b04126
Merge "Properly hide and show inspectors."
2012-06-21 05:56:30 +00:00