Commit graph

2904 commits

Author SHA1 Message Date
ryasmeen@wikimedia.org 0245af2047 [BrowserTest] Fix only Media Test
The media test was passing against garbage wikitext markup match.
Fixed the steps so that it fails when it should.

Change-Id: I3d8dbc959c6244968dd9ac58af663b81cb115dc6
2015-02-09 15:41:42 -08:00
jenkins-bot 94f581b04f Merge "Update VE core submodule to master (83a526a)" 2015-02-09 20:55:42 +00:00
Translation updater bot a7faafda0e Localisation updates from https://translatewiki.net.
Change-Id: Iad86b251f2c6077be11060ba6976dffe2b01f84e
2015-02-09 21:38:24 +01:00
Roan Kattouw 396eb606a6 Update VE core submodule to master (83a526a)
New changes:
23a9e11 Localisation updates from https://translatewiki.net.
9f1350f Update UnicodeJS to v0.1.3
f869803 Localisation updates from https://translatewiki.net.
ce11fb3 Use css class rather than jQuery show/hide
0d4584c Fix definition of ve.Range#containsRange
8a5c7d9 Fix rangeInsideOneLeafNode
8ce5f60 Localisation updates from https://translatewiki.net.
d2104aa Track originalHtml in internalItems
9823624 Localisation updates from https://translatewiki.net.

Local changes:
Update tests for internalItem originalHtml change

Bug: T88650
Change-Id: Ie7532cade7e3006e1bf39c12c97962da415ab993
2015-02-09 11:29:43 -08:00
Cmcmahon 3db521ce41 [BrowserTest] make References test pass
Somehow the Insert element got removed from the page object. Fixeded.

Change-Id: I970d4824ebeed817f621b09714e0d58d99bee573
2015-02-09 10:36:44 -07:00
Cmcmahon 18679b74ba [BrowserTest] Make media tests pass
Like in the Cite tests, need a sleep to make the tests pass
locally.

Updated a locator also

Change-Id: Idd962e110fd7191325bdac7e641960858de1db9e
2015-02-09 10:24:12 -07:00
Cmcmahon dd671b4843 [BrowserTest] update Cite test to pass
I'm hoping the sleep() calls here are temporary. VE seems to be
loading an intermediate page before showing the diff view, or
sending an invalid onload event or some such.

Also updated the locator for the Basic text input

Change-Id: I73795f6b1ff0da42f8afd92598ab6786c9a0b88b
2015-02-09 10:00:41 -07:00
Translation updater bot b5fa02b843 Localisation updates from https://translatewiki.net.
Change-Id: I810b5128799e416aabde17769fa2f7bdaa03bb57
2015-02-08 21:50:43 +01:00
jenkins-bot fec2d12d0f Merge "MWCategoryItemWidget: Update CSS for OOUI changes" 2015-02-08 01:50:14 +00:00
Translation updater bot 5a9cc8a717 Localisation updates from https://translatewiki.net.
Change-Id: I9b5bafe3489ad1bbe8e489048222690eca2658ed
2015-02-07 21:49:31 +01:00
Bartosz Dziewoński 7609a35ecc MWCategoryItemWidget: Update CSS for OOUI changes
* Add margin-right: 0 to suppress OOUI's inline spacing feature. We
  can't use margin on the widgets because of how draggable works (there
  may not be "gaps" between draggable elements or funny things happen).
* Set our inline spacing to 0.5em (2 × 0.25em) rather than 0.75em, to
  match OOUI styles.
* Space at bottom and right rather than at top and right.

Change-Id: I90f4f47dd0c55de18e5915e610a76d0140438cc3
2015-02-07 19:04:50 +00:00
Roan Kattouw 3f15c5be5d MWMediaDialog: Focus the right thing on ready, depending on the panel shown
The ready handler unconditionally focused the surface, even if
a different panel was shown. Prior to aa9eb9545 this didn't
actually break the search mode, because the search input was
focused after the image repo information came back, which
usually happened after ready. However, aa9eb9545 instead focused
the search input from the setup process, which is too early.

Also introduce this.currentPanel as a way to track
which panel is currently visible.

Bug: T88881
Change-Id: I0189fbeed73ee9103e45fec4a1bc8d4ee1b6ed40
2015-02-06 18:12:06 -08:00
jenkins-bot ac9f81cd2c Merge "Refactor MWMediaSearchWidget to use a queue and providers" 2015-02-07 01:15:38 +00:00
Moriel Schottlender aa9eb95455 Refactor MWMediaSearchWidget to use a queue and providers
Change the media search widget to work with resource queues and
providers. Create providers based on the user's filerepo settings
and aggregate their responses with the media queue. Stop asking
for more results from providers that are depleted.

Also fixes a rather nasty infinite-loop bug where the API returns
only very few images, and the UI keeps asking for more.

Bug: T78161
Bug: T88764
Change-Id: I65aed3446cd1f056476c56e6e04522c70e49e595
2015-02-06 16:45:56 -08:00
jenkins-bot 70ccff87c2 Merge "[BrowserTest] [WIP]Fixing the test media_general_settings.feature" 2015-02-06 23:41:38 +00:00
ryasmeen@wikimedia.org cefb9b265a [BrowserTest] [WIP]Fixing the test media_general_settings.feature
Change-Id: Ic83477f12db08ed25452f19ca3dc410940a8ebf5
2015-02-06 16:16:33 -07:00
Bartosz Dziewoński a3becc245a ve.ui.MWTocWidget: Rename .toggle property
It conflicts with the #toggle method. This happened to work because we
never called .toggle() here, but 8a53b2cd introduced such a call.

Follow-up to 8a53b2cd.

Bug: T88831
Change-Id: I4dd955d015d2bda50e4146b0ae2ddff557dcd346
2015-02-06 22:39:05 +01:00
jenkins-bot d3206394da Merge "Use css class instead of jquery show/hide" 2015-02-06 19:08:01 +00:00
Moriel Schottlender 8a53b2cd07 Use css class instead of jquery show/hide
Replace instances of .show() and .hide() with ooui 'hidden' class
to make performance better.

Related ooui change: Ibf7c99aa4aad

Bug: T87420
Bug: T88736
Change-Id: I3af8a322e88b7ba3364f350819d6dbcdc8b13270
2015-02-06 11:03:59 -08:00
Alex Monk 4082af335b Make category widget items draggable
Depends on I859ff276

Bug: 50809
Change-Id: Idae3e293a6f7c29b70bc27c3db58e014d23b3e47
2015-02-05 16:06:45 -08:00
jenkins-bot b4e20aacec Merge "mw.ViewPageTarget: Use CSS instead of JS for DOM hiding/muting" 2015-02-05 22:37:56 +00:00
Translation updater bot 90943e7789 Localisation updates from https://translatewiki.net.
Change-Id: I6f4b39a53538eb8f6f7f586601eafe8b8940b4c9
2015-02-05 23:07:48 +01:00
Roan Kattouw 1e4c3f86c6 Remove useless mixinClass call from MWCategoryItemWidget
The parent (ButtonWidget) already mixes in IndicatorElement.

Change-Id: I49fd72514d9b177eaca2b0295192384bca9e0f97
2015-02-05 13:09:58 -08:00
Amir E. Aharoni 2e0b191dda [BrowserTest] Refactor offset_element and browser_zoom
offset_element was used for iframes, and now there are no iframes,
so there is no reason to use it.

As for browser_zoom, it makes more sense to do it in a separate function
and not as a parameter to capture_screenshot.

Change-Id: Ibfce33b7a56d883cc1a6c92c19d40c499681fa47
2015-02-05 12:40:28 +02:00
Amir E. Aharoni 4a73b3e4b1 [BrowserTest] Rename iframe to window_frame
It's not an iframe anymore, so the name shouldn't be confusing.

Change-Id: Id93595d56d7d88871ab79ca91e1714d9a70fad17
2015-02-05 10:32:21 +00:00
Amir E. Aharoni 4bab4fd921 [BrowserTest] Restore the formula screenshot scenario
* Restore the Formula editor screenshot scenario, which was disabled in
  I3e892baa9cb2c8c1303fab232a2b1c64ebdd8f26
* Get the 'More' element clicked to show the formula item.
* Fix the definition of the formula editor textarea element.

Change-Id: Ib50d0381f5743db1f6678609cd4eca5a56a8682b
2015-02-05 10:28:37 +00:00
Amir E. Aharoni 8063c6c754 [BrowserTest] Restore page settings language screenshots
* Add classes to elements in the page settings dialog boxes
* Restore the scenario that was disabled in
Id41d1329d22679b6a61201ceafc81eafa222d909

Change-Id: I5636e744daec2adf013d399bfb019e4d47912083
2015-02-05 12:16:48 +02:00
Amir E. Aharoni ae4417e60d [BrowserTest] Click the editable area with .when_present
The editable area sometimes didn't appear, so a .when_present
call is added to check that it's on the screen.

Bug: T88663
Change-Id: I0c5e29a9d7f9d0a22ca8392df9f7a5b857f20d7d
2015-02-05 12:13:15 +02:00
jenkins-bot 130edbfe62 Merge "[BrowserTest] Shorten all capture_screenshot lines" 2015-02-05 09:19:23 +00:00
jenkins-bot 3351d84bf0 Merge "[BrowserTest] Restore the indentation list screenshot scenario" 2015-02-05 09:17:55 +00:00
jenkins-bot c73d949ba7 Merge "[BrowserTest] Show the complete insert pull-down in screenshots" 2015-02-05 09:15:07 +00:00
jenkins-bot 8238658ad7 Merge "[BrowserTest] Consistent names for variables that refer to down-arrow" 2015-02-05 09:12:25 +00:00
jenkins-bot 04f398beaa Merge "[BrowserTest] Shorten lines for clarity" 2015-02-05 09:10:53 +00:00
jenkins-bot 8900b2ce92 Merge "[BrowserTest] Simplify the Selenium selector for the Save button" 2015-02-05 09:05:36 +00:00
Timo Tijhof 62c1d64ad0 mw.ViewPageTarget: Use CSS instead of JS for DOM hiding/muting
* Use .ve-activated for elements changed in activate()
  - hideReadOnlyContent()
  - mutePageContent()
  - mutePageTitle

* Use .ve-active for elements changed in onSurfaceReady()
  - hidePageContent()

* Set 've-activated' class from activate() instead of transformPage()
  to consolidate reflows and minimise DOM interaction. It's still
  in the same (synchronous) execution path, but a few statements
  earlier now.

* Remove obsolete #toc wrapper. This <div> (with data property
  to distinguish it from potentially foreign parents in the future)
  was there to aid slideDown/slideUp animations, because those
  don't work well on table elements. See eba7d58dd1.

* Remove obsolete setTimeout in restorePageTitle().
  The removal of .ve-init-mw-viewPageTarget-pageTitle was delayed
  by one second (introduced in Ibc3fa2fb7 / 4cc88b9850). This
  was to account for a jQuery animation we no longer use.

* Remove unused '.ve-init-mw-viewPageTarget-transform-muted'
* Remove unused '.ve-init-mw-viewPageTarget-transform'
* Remove unused '.ve-init-mw-viewPageTarget-pageTitle'

The resulting stylesheet exposes that we're not consistent in
whether elements hide immediately (ve-activated) or once the
surface is ready (ve-active). This is intentionally kept as-is
within this commit.

Of the different elements that had their opacity changed, only
firstHeading was being animated. This animation was removed.

Bug: T88590
Bug: T87160
Change-Id: I87033456f715d99a88425e38e8ac5171144f4ec8
2015-02-04 19:24:29 -08:00
jenkins-bot 21f39e3086 Merge "Unbind watch event handler in VPT when necessary" 2015-02-05 02:09:17 +00:00
Alex Monk dd52503b6a Unbind watch event handler in VPT when necessary
Caught by Timo in I1df2836f

Change-Id: I0f0af71cdca26f7e8d13f9ea50d22c833b6e1683
2015-02-05 01:16:11 +00:00
jenkins-bot 110f6a2550 Merge "MWTransclusionDialog: Add a little margin to the addTemplateFieldset" 2015-02-05 00:42:14 +00:00
Translation updater bot 2180830ee2 Localisation updates from https://translatewiki.net.
Change-Id: I91f3598488bc79fe0b502dfc877cb238c90de003
2015-02-04 22:29:45 +01:00
James D. Forrester ccbf32534f MWTransclusionDialog: Add a little margin to the addTemplateFieldset
Change-Id: I2549a9ca3df788cf92761b638a14760f8c413f46
2015-02-04 11:45:06 -08:00
jenkins-bot a7762b66a5 Merge "Adjust to ooui's show/hide css change" 2015-02-04 17:03:45 +00:00
jenkins-bot b43e798bb4 Merge "Make API module's LinkCache data transmission format more efficient" 2015-02-04 01:18:21 +00:00
jenkins-bot b5ea06c276 Merge "Improve references test data" 2015-02-04 01:16:19 +00:00
Roan Kattouw bc51095888 Improve references test data
* Remove unused extsrc
* Add <a>s inside of reference <span>s
* Add <li>s inside of reference list
* Change reference list to one for the g1 group rather than the main group
* Consequently, the reference defined inside the reference list moves to g1
** Due to a bug, explicitly set group="g1" on that ref for now

Change-Id: I266a4323c7353e00bd4288d5de51c252bbcdf3d7
2015-02-03 16:43:15 -08:00
jenkins-bot 82784d2217 Merge "[BrowserTest] Test for checking General Settings for media" 2015-02-04 00:30:16 +00:00
Translation updater bot 94b949db77 Localisation updates from https://translatewiki.net.
Change-Id: I91dae3d789b001b65429a6c38515011f9dfddb14
2015-02-03 22:57:12 +01:00
ryasmeen@wikimedia.org fcb9473c68 [BrowserTest] Test for checking General Settings for media
Change-Id: I503c01642a9fc23684912909e8da8e61998528a6
2015-02-03 21:53:40 +00:00
Roan Kattouw e367ecc948 Make API module's LinkCache data transmission format more efficient
We used to send data like { title: { missing: true|false } }
With this change, we send data like { missing: [titles], existing: true|[titles] }
where 'existing' is set to true (assume all non-missing titles exist)
for current revisions and to an array of existing titles for
old revisions.

This is because we always output this data for links in the current
revision, even when loading an old revision: in that case we rely
on the client to request the omitted information, so there we can't
assume that all pages we don't have information about exist.

Bug: T88259
Change-Id: I7b58b3f669cc78fd81b60859cf76928a9087066f
2015-02-03 11:30:40 -08:00
jenkins-bot 0e926f5fcd Merge "Wait with showing edit notices until after the welcome dialog is closed" 2015-02-03 18:44:02 +00:00
jenkins-bot 07e95ac365 Merge "[BrowserTest] Updating test for Media Settings interface" 2015-02-03 07:42:33 +00:00