Commit graph

15781 commits

Author SHA1 Message Date
Bartosz Dziewoński e9ef3a6f78 ve.init.mw.MobileArticleTarget: Remove unused method
ve.init.Target#isToolbarOverSurface has been removed in VE/VE in 2016:
8b1208cb976278bd44025e6d2c86a3ea6ed8c177. Nothing calls this method.

Change-Id: I9640978b45e568412db4b1c5aa80631a68d847b2
2019-03-23 03:52:01 +01:00
Bartosz Dziewoński f2fc7b8e73 ve.init.mw.MobileArticleTarget: Bring the toolbar back into view after it scrolls out
On iOS Safari, when the keyboard is open, the editor toolbar could
previously be scrolled out of view, due to how the keyboard affects
the viewport (or rather how it doesn't).

Detect when this happens and bring it back in, with a similar slide-in
animation as when the editor loads. Technical restrictions prevent us
from really keeping it in view at all times, and I think this is the
best we can do (and it looks almost intentional).

Bug: T218414
Change-Id: I5eed360d4644815bc9829fbc6b0ffd79b205d10b
2019-03-23 00:59:50 +01:00
James D. Forrester 378db0165d Update VE core submodule to master (d79dbfc9c)
New changes:
1d4ae6e9b Update OOUI to v0.31.1

Change-Id: I705d6274c5baed2e6b5a75739a8c116980efce5b
2019-03-22 12:06:56 -07:00
Bartosz Dziewoński 73561f7aba ve.init.mw.MobileArticleTarget: Merge in downstream code from MobileFrontend
It will be easier for us to maintain this way. The code I'm moving had
a lot of comments saying that it should be moved here.

See MobileFrontend change Ibe192360bdecab86519de1781f66f90a3441c551.

Bug: T218946
Change-Id: I908e035ec245a9b190f05e64c35dbb29936434de
2019-03-22 18:30:05 +00:00
Bartosz Dziewoński 1664bcd6aa Update VE core submodule to master (af9089ac5)
New changes:
5413e0a6f Localisation updates from https://translatewiki.net.
f92afddaa ve.ce.Surface: Stop editor scrolling to selection constantly on iOS

Bug: T218635
Change-Id: I2a240bfbf1f9a3c7c7726e3b6ee2776eb134d1f8
2019-03-21 19:35:02 +01:00
Bartosz Dziewoński 5806329748 MobileArticleTarget: Remove padding below the surface on iOS
It was here because our old hacks prevented the viewport from being
scrolled, so the keyboard would always cover the last few lines of
the surface. But it is no longer necessary after we ditched the iOS
scrolling hacks in MobileFrontend.

Bug: T217769
Change-Id: Iaf3f86c0fc43f75d11a43462721f44d62abc6eb3
2019-03-21 18:33:02 +00:00
Bartosz Dziewoński a89896a500 MobileArticleTarget: Remove broken iOS override for #scrollToHeading
This is no longer necessary and doesn't work after we ditched the iOS
scrolling hacks in MobileFrontend. And the default implementation works!

Bug: T218429
Change-Id: I5fba78a3877901dac5afda46d3004c07cad383d0
2019-03-21 18:32:54 +00:00
Ed Sanders d6d48ff4b8 Introduce a 'mobile-ab' config option for section editing
This enables mobile section editing if the user is logged
in and has an odd user ID. Otherwise it is disabled.

Bug: T218851
Change-Id: I2c22d7636ae11d2db7780ae5adb3abe9df532b7c
2019-03-21 13:18:10 +00:00
Ed Sanders 970cca735d Suppress slugs between floated images
Logically depends on Idb4a58fa616 in core.

Bug: T107745
Depends-On: Idb4a58fa616dedb29d42bdf659a7497451f8eb6c
Change-Id: I206bf1a15cbac487b0d937a1b0447e0b9113156e
2019-03-21 11:33:27 +00:00
Translation updater bot 7e3e7e9c5a Localisation updates from https://translatewiki.net.
Change-Id: I660e306b25946b528ce9e40c4f66ff62fb4834d6
2019-03-20 22:27:35 +01:00
Translation updater bot f6d082926b Localisation updates from https://translatewiki.net.
Change-Id: Ida951876a80d41457d44689ed382d238d3af5765
2019-03-19 22:17:11 +01:00
jenkins-bot 074973f01d Merge "Remove special handling for category and file pages" 2019-03-19 19:24:13 +00:00
James D. Forrester 6f6d80416a .gitmodules: Update gerrit URI syntax, deprecated ages ago, now unsupported
Bug: T218694
Change-Id: I61a5e68e74176f9f25bddf154eb100b224a018f5
2019-03-19 16:49:03 +00:00
jenkins-bot 2101a0f661 Merge "Directly call action=query&prop=langlinks from JS rather than PHP wrapper" 2019-03-19 14:32:21 +00:00
jenkins-bot e93c127e5c Merge "ApiVisualEditor: Fix PHP warning caused by unexpected API metadata" 2019-03-18 22:30:35 +00:00
Bartosz Dziewoński a5c5257e71 Directly call action=query&prop=langlinks from JS rather than PHP wrapper
When this code was written in 2013 (1a5bdd5bd2),
the langlinks API did not have a way to return the language names (autonyms).
This has been added in 2014 (4ba3a9aea96ee21c035c69999be23580e23f4e0a).

Change-Id: I70edb846d94b1108b079caf5915532234190da8f
2019-03-18 23:27:44 +01:00
Translation updater bot d0d7cc8745 Localisation updates from https://translatewiki.net.
Change-Id: I3374f163e15c8aa263eace13ffbe331992a17d9f
2019-03-18 23:08:06 +01:00
Bartosz Dziewoński c0ab5133eb ApiVisualEditor: Fix PHP warning caused by unexpected API metadata
Bug: T218464
Change-Id: I272ca718932cb9cd57d121c9f564c64e11f9deff
2019-03-18 23:01:09 +01:00
Ed Sanders f3b7a6d4c8 Update VE core submodule to master (a61616907)
New changes:
360cc0a48 ve.ui.FragmentInspector: Add test case for collapsed selection inside a word that is partially linked
8369d69ef Update OOUI to v0.31.0
293215d32 Always give inline slugs an src
7f78e9502 ContentEditableNode: Disable spellcheck when read-only
8bb1eb598 Scroll 60px past toolbar on iOS too to avoid context menu clash
5221db7a0 Hide the caret (text cursor) when read-only
d66826a0d Set Chrome inline slugs to 0px width instead of adding src

Bug: T202723
Bug: T217510
Bug: T217740
Bug: T218331
Change-Id: I2e961f2b753e68793518eb4bcfbb7b3e8b5c8347
2019-03-18 20:53:46 +00:00
Translation updater bot daba809646 Localisation updates from https://translatewiki.net.
Change-Id: I97bf413440429a50d4d9fcec7e190d503dc8c4a7
2019-03-17 22:14:27 +01:00
Translation updater bot a6688dd9dc Localisation updates from https://translatewiki.net.
Change-Id: I56baad3df8728023d3304d9ddf5a7a3c04114973
2019-03-15 22:37:08 +01:00
Translation updater bot 2ca6dc4b16 Localisation updates from https://translatewiki.net.
Change-Id: I1a707baf22839ed19b18df8ad781d5867becfc41
2019-03-14 22:52:17 +01:00
Translation updater bot f0b719cb89 Localisation updates from https://translatewiki.net.
Change-Id: I41e1b0ad5a21ec80d676ecaf4d33b27de67dfd29
2019-03-12 22:29:36 +01:00
Umherirrender de8b4b5d29 Use php null coalesce operator ??
Change-Id: I756fa99084cbb86357ac840b3338d296863eecc4
2019-03-12 21:27:47 +01:00
Ed Sanders 21ade64903 Update VE core submodule to master (8f10e06af)
New changes:
7c3584a4f Add test coverage for FragmentInspectors
78104cf8f Refactor AnnotationInspector for readability
d1b8ed35a Localisation updates from https://translatewiki.net.
682d83545 Follow-up Iefaaa2a7e70: Fix replace mode to clear existing annotations
b9d750dd8 Add more inspector tests
c099abbfc Make CommentAnnotations multiline

Bug: T217957
Change-Id: I381794c1af755cc7e4aea520aca20c6cbfc75dd2
2019-03-11 17:17:44 +00:00
Translation updater bot 037670c884 Localisation updates from https://translatewiki.net.
Change-Id: Id0c7f99773f190954d527b3d1e2a2f8c74e0c861
2019-03-10 22:27:59 +01:00
Ed Sanders 1ffb574450 Edit summary autocomplete
Bug: T50274
Change-Id: Ida462f3dea325902459546af97e66cd9d0c86166
2019-03-09 14:03:27 +00:00
jenkins-bot 73063b4f8c Merge "Fix section param in historical diffs" 2019-03-09 01:14:40 +00:00
jenkins-bot a7f2bfc344 Merge "ve.init.mw.ArticleTargetLoader: Better document pageName parameters" 2019-03-08 23:28:51 +00:00
Bartosz Dziewoński 7acbc4d44c ve.init.mw.ArticleTargetLoader: Better document pageName parameters
Bug: T217826
Change-Id: If136b7b9dc747a75062f88f8decc1128938fee9f
2019-03-08 22:46:10 +01:00
Translation updater bot 891a03b400 Localisation updates from https://translatewiki.net.
Change-Id: Ib5310ae8551c7edb52fcc8373f8fdc0a6f2d0869
2019-03-08 22:29:38 +01:00
jenkins-bot f501a5238b Merge "Fix return type of ApiVisualEditorEdit::saveWikitext" 2019-03-08 20:50:04 +00:00
James D. Forrester b5d433df21 Update VE core submodule to master (da38da984)
New changes:
e2a8e4f0d Fix AnnotationInspector read-only support
4f27ec68c Localisation updates from https://translatewiki.net.
cdbe0321b Update OOUI to v0.30.4
da38da984 Follow-up I74d1dbc6: Use isNew instead of isEditing

Bug: T217454
Change-Id: I4eee93150591b934c342017fbd58688d5e4cae16
2019-03-08 16:00:10 +00:00
Translation updater bot c2e57532e4 Localisation updates from https://translatewiki.net.
Change-Id: I8992271c6abbf90c2a123b026a06231c5f1e8bfc
2019-03-07 22:41:09 +01:00
Ed Sanders 2e33841b5a Fix section param in historical diffs
Passing section=undefined resulted in no <section> tags being
unwrapped, which broke the historical diff. Ensure 'null' is
used instead for whole documents.

Bug: T217752
Change-Id: Iec33e6ab83bfbd011df9dc05f4daccc26b1df8b5
2019-03-07 12:01:44 +00:00
jenkins-bot 085f21792b Merge "rebaser: pushState when calling showForm" 2019-03-06 12:13:02 +00:00
Translation updater bot 9b66e337b9 Localisation updates from https://translatewiki.net.
Change-Id: I74ed5d2d3ce6daa0719326785f320fbf6a780380
2019-03-05 22:43:00 +01:00
Translation updater bot 9445ffe80c Localisation updates from https://translatewiki.net.
Change-Id: I58146345f729b744a3054d92ab1ffa7a53bbae9f
2019-03-04 22:16:25 +01:00
jenkins-bot 476ffbba68 Merge "Use DerivativeContext in ApiVisualEditorEdit" 2019-03-04 19:09:19 +00:00
Umherirrender c9a3bf9fa5 Use DerivativeContext in ApiVisualEditorEdit
Using DerivativeContext also makes the code easier to read.
getContext() returns an IContextSource, in this interface has no
setRequest() method and this can fail for some kinds of IContextSource.
$view is a ContextSource, which implements setContext().
This also allows us pass in a new context with the right request object,
and also to set the title so we don't have different titles
on $view and the main context.

Change-Id: Ia575cd6163defeb423a542e342034cac5eb6108c
2019-03-04 18:36:47 +00:00
jenkins-bot 5aec469952 Merge "rebaser: Fix export dialog title" 2019-03-04 14:49:46 +00:00
jenkins-bot fefc7351a6 Merge "MWTransclusionNode: Comment strange matchTagNames values" 2019-03-04 14:49:43 +00:00
Ed Sanders b3a35790c1 rebaser: Fix export dialog title
Change-Id: Ib76adbdb8b6547e42968f73cc196d7b8817e25f0
2019-03-04 14:26:39 +00:00
Ed Sanders b0b8194faf rebaser: pushState when calling showForm
Change-Id: Id650acbcc4d0ba699fa1264acfd8ab6249315806
2019-03-04 13:25:26 +00:00
jenkins-bot f3cb757811 Merge "rebaser: Bind special tab click to showForm" 2019-03-04 04:44:26 +00:00
Reedy 2fb0ed0269 Use ExtensionRegistry rather than class_exists
Change-Id: I6e8fb5e5f3a9ef5b8ba4787c43ee1216ea03bd7e
2019-03-02 23:29:09 +00:00
Umherirrender a07ad01594 Use ::class for class name resolution
Available since php5.5

Change-Id: I9392155193275d20a82bde8eb7964d466e190f6b
2019-03-02 23:46:12 +01:00
Translation updater bot 995ec0d78b Localisation updates from https://translatewiki.net.
Change-Id: Icb60c2437b009b5aa249dc15eeff653b7ea98ba5
2019-03-02 22:42:50 +01:00
Umherirrender 8c1eda388e Fix return type of ApiVisualEditorEdit::saveWikitext
Change-Id: I523d8097b39d80fc7082c64009b49b36f8a296a7
2019-03-02 18:04:14 +00:00
jenkins-bot 266a2bf036 Merge "ApiVisualEditor: Separate out templatesUsed from metadata" 2019-03-02 01:49:06 +00:00