We were setting the height to 2.25em which just happened
to be right, but it depended on the browser's default
line-height being a certain value. Now that that's changed
with unisolation, the alignment breaks.
Instead of using a magic value, use height: 100%; so it
takes the parent's height. We don't even have to make the
parent position: relative; because it already is.
Also change the width to 2em, which is a much more defensible
value than 2.25em. Previously 2.25em kind of made sense because
that was also the height (resulting in a square box), but
now we don't have that excuse any more.
Bug: 72962
Change-Id: Id617bfaafefd1fc1530fbee29be5d935ec486b92
It wasn't being loaded at all, but we didn't get any errors
because every single call to RangeFix was in a try-catch.
We did, however, notice that context positioning was broken,
this fixes that.
Change-Id: I0a981f0c70a9a7bbd89ee2946cb7c566a63490aa
New changes:
2cc219a Update OOjs UI to v0.1.0-pre (571f26d0ab)
3543cb7 Protect against offset=-1 in insertContent()
7a3d456 [BREAKING CHANGE] Move selection restrictions from tools to commands
3d847bb Disable desktop context on table selections
41282dd Missed function rename from RangeFix change
dd6c8b8 Support toDomElements returning an empty array
9be6464 Placholder -> placeholder
9bdd0a8 Restore basic styling to toolbar in core target (only)
Local changes:
Move selection restrictions from tools to commands
Change-Id: I88f3d04946bd1d03ed001d747475a8b495a0f64c
This code was somehow broken by Ia47bc897 (wtf, how?)
Actually removing it seems to do no harm (wtf?), as far as I've been able to tell...
Bug: 72906
Change-Id: If7eb34a20cc8060b594a567278241b02a8ee327a
0165a53 overlooked the fact that 'name' is also passed to
the MWTemplateModel constructor, and there it really does
always need to be a string, not magically either a string
or an mw.Title object. Oops :(
Bug: 72961
Change-Id: I0b20f0768aae4d9cc9f7af268abd0a704b6adc3a
Now that we have .getTitle() as a method in MWTitleInputWidget, replacing the callers
of MWTitleInputWidget.getValue() with .getTitle(). This fixes a bug in the .getTitle()
method in MWTitleInputWidget which was not taking the namespaces into account before.
Also fixes: the error when entering "Talk:" as a template title. The button to add template
remains disabled when "Talk:" is given as an input to the title here.
Bug: 71998
Change-Id: I1e629a61ec8b035d93a4b7acfecab81934019166
This was needed to make the ComboBoxWidget initialize
its selection, but Idcbf38c53 makes that happen automatically.
Depends on Idcbf38c53 in oojs-ui.
Bug: 72783
Change-Id: I8d3a014f862ece7f4f201af205a8a7ca6c365eaa
New changes:
38fc5bb Replace native range rectangle hacks with RangeFix library
4713b8e Disable cell editing when a context is opened
1113a13 AUTHORS.txt: Re-update for late 2014
37af5c4 Prevent clicks on focusable nodes in tables
2152877 Localisation updates from https://translatewiki.net.
b766ecc Update OOjs UI to v0.1.0-pre (eee616d664)
20cb077 Follow-up Ifb7ffb1: Update demo.js for breaking OOUI change
6760cdd Localisation updates from https://translatewiki.net.
555c6ea Set insertion annotations when typing over cell contents
819ad6b Fix width of demo page dropdown
9f4705c Catch backwards selection error in Firefox
ac8a4e8 Add missing focus call to pasteTarget
b034657 Add support for non-table nodes in tables (e.g. aliens)
25aef0c Fixes to onDocumentDrop
622957f Add support for dropping text/html from external sources
Change-Id: Ic704b95c1dc91a1ae74f9a60101cb949b34c9e0d
Now that the toolbar hides extra features by default, we don't need to
use autoAddToGroup and autoAddToCatchall over-rides.
Change-Id: I493f7d46a3f77e7c62af05f8e05ae4dde7147e4b
MWCategoryInputWidget:
* Use @inheritdoc
* Don't modify data parameter in getLookupCacheItemFromData()
MWLinkTargetInputWidget:
* Remove this.choosing in favor of setLookupsDisabled()
* Explicitly close menu on choose
* Remove manual emission of change events
** This looks ridiculous, it doesn't seem to be necessary,
and it causes infinite event loops. But I'm very curious
why this was added in the first place.
* Remove onLookupInputChange override that is now unnecessary
* Use {} rather than [] for fake empty result
* Prevent programmatic focus from opening the menu
MWTitleInputWidget:
* On choose, close menu and disable lookups while changing value
* Use @inheritdoc
* Remove mentions of "template" from getTitle() documentation
Bug fixed:
* When choosing a suggestion in MWTitleInputWidget,
new suggestions would be loaded and the menu would reopen
Depends on Iecae9b582 in oojs-ui.
Change-Id: I716f99bb464a5cebd4f17701197f768e4e0e02a9
Add Marielle to principal authors (previously missing).
Add Andrew Garrett, Brad Jorsh, Dan Duvall, Derk-Jan Hartman, Frederico Leva,
Jon Robson, Kaity Hammerstein, Kunal Mehta, Niklas Laxström, Quim Gil, Sam
Reed, Sam Smith, Vikas S Yaligar, & addshore, Helder and Jiabao to the patch
contributors list, based on git shortlog perusal. Moved Neil Kandalgaonkar to
the VisualEditor-core list only.
Change-Id: Ieef11abf208216f22a95cb85cbc8ce54a7f30501
