Commit graph

166 commits

Author SHA1 Message Date
Ed Sanders b19883e8d8 Update VE core submodule to master (c788040b1)
New changes:
ace73e1dd Show selection size in merge cells context item
a5a3c576d build: Run npm audit --fix as of 2023-12-07
1fd5de1cf build: Upgrade svgo from 3.0.2 to 3.0.5 and re-run

New i18n keys:
visualeditor-table-selection-dimensions

New files:
src/ui/styles/contextitems/ve.ui.MergeCellsContextItem.css

Change-Id: I30653d829ae77b5f356eba00e476ccdeba65d621
2023-12-08 16:40:03 +00:00
Ed Sanders c9ab1d148e Update VE core submodule to master (d90ae3a9c)
New changes:
88fe7eef7 Localisation updates from https://translatewiki.net.
54d9ce473 Localisation updates from https://translatewiki.net.
ddb809ba1 Implement PersistentContextItems
7fd68cde3 Add a "review mode" to the surface view
850d0655c Localisation updates from https://translatewiki.net.
d90ae3a9c Localisation updates from https://translatewiki.net.

Change-Id: I4439a413045125972d9756a5a6f149d7abf82f82
2023-08-10 13:59:51 -04:00
David Lynch fde414149e Update VE core submodule to master (8cd2c4933)
New changes:
4ac9b4290 Localisation updates from https://translatewiki.net.
5db1e6972 Localisation updates from https://translatewiki.net.
439b29f3e PreviewElement: Remove slugs and nails using JS instead of CSS

Bug: T341901
Change-Id: I5da36fe06bd6631f17172029261b1c18daa72bf4
2023-07-17 10:38:04 -05:00
jenkins-bot 7ae61934a3 Merge "Remove remains of lossy-switching and discard-switching" 2023-07-11 15:34:52 +00:00
Ed Sanders ea03287908 Convert MWPopupTool into MWHelpListToolGroup
The popup contains three buttons, one of which already exists
in core as a tool. By converting them all to tools we can reduce
some duplication, and better integrate with other features
that use the tool factory, such as HelpCompletionAction.

Bug: T339153
Change-Id: I81d217bc1ab9a1a6a9bf7c7ad588c2a3216b10db
2023-07-01 11:10:53 +01:00
Bartosz Dziewoński 34c6d3e1a3 Remove remains of lossy-switching and discard-switching
After the demise of RESTBase we are always able to switch from
wikitext to visual mode with changes, and we no longer need to
support these two poor experiences.

Bug: T339871
Bug: T339872
Change-Id: I2be4068447b21e16c87db0e56d6422ea64ba4708
2023-06-25 09:16:45 +00:00
Ed Sanders 5499de28fe jsduck: Add missing categories for MW classes
Change-Id: I5e0ce17ed5de47fe4d3079636a0d729cf811fe7a
2023-06-12 19:04:37 +01:00
Bartosz Dziewoński ac85050f2d Update VE core submodule to master (549e36956)
New changes:
2ec47e304 Localisation updates from https://translatewiki.net.
08dea65b1 Reuse overlapping rect logic from ve.ce.FocusableNode
fcde3bed1 Mark Target.static.actionGroups as deprecated
c2a68aa18 CommandHelpDialogTool: Use 'keyboard' icon instead of 'help'
4b048db57 Create a tool to launch help completions from the toolbar

Bug: T338254
Change-Id: Icaef215b9fe025d6ef0d7f766d2efe629c45665f
2023-06-09 18:36:16 +02:00
David Lynch 50c646050d Update VE core submodule to master (fd2f048e4)
Also supporting changes to support the new HelpCompletionAction,
including adding a preference to disable it if required.

New changes:
985b553cc Localisation updates from https://translatewiki.net.
aa26e27dc Localisation updates from https://translatewiki.net.
4cdc753ab Update OOUI to v0.47.0
bfc96a7ee Completions: always abandon if the first input is a space
616a6458f Fuzzy command bar
92b6525a2 Tweak the fuzzy command bar's behavior
fd2f048e4 Fuzzy bar: change how command groups are generated

Change-Id: Ic77b8822baecf5ad1ab466d94df29bb945172b55
2023-05-20 22:04:27 +03:00
Bartosz Dziewoński cc72825835 Re-apply "Remove references to mediawiki.Uri"
This reverts commit afe3b7187e.

Bug: T325249
Change-Id: Ie2ce4816cd8fb6cc9805e0fd70dadb337719c551
2023-02-01 22:46:14 +00:00
Bartosz Dziewoński afe3b7187e Revert "Remove references to mediawiki.Uri"
This reverts commit 15bbafbe8c.

Bug: T328143
Change-Id: I57e6d953ed5a1735541987a256ad39037170da5a
2023-01-30 13:52:26 +00:00
Bartosz Dziewoński 15bbafbe8c Remove references to mediawiki.Uri
Remove dependencies (except a single one that we actually need)
and some config that allowed it to be used in doc comments.

Bug: T325249
Change-Id: I0db6e4ab1c025ac3868d2dc886c13a09d91f8086
2023-01-23 14:59:35 +00:00
Ed Sanders 2df8a95ac3 Update VE core submodule to master (035756895)
New changes:
4355d697a Replace ListStorage with ConflictableStorage
978061f86 Update SafeStorage and ConflictableStorage with expiry functionality
79019ed88 ve.dm.Surface: Support storage expiry

Local changes:
* Pull through conflictable storage

Bug: T218663
Change-Id: I36e49c01e9f2ddb7d362d539b72a4beca925bcb7
2023-01-21 10:41:21 +01:00
Ed Sanders a625d0b7b7 Fix logic for getting the *available* preferred editor
Factor out getAvailableEditPageEditor from getEditModeFromUri
and use instead of getEditPageEditor everywhere.

Bug: T316776
Change-Id: I34bab092b829124c52f8bc0e262a9c3aa17f2c52
2022-09-01 22:25:53 +02:00
Adam Wight 9f2c8f0928 Copy BookletLayout implementation from ooui-js 0.44.0
Bring over the ES and Less implementation from ooui-js and rename to
fit it into the VE hierarchy, but don't make any other substantial
changes.

Inlines the wikimediaui-themed styles, ignoring apex styles, and
hardcodes the Less constants.

Bug: T310865
Change-Id: Id43dafdf11c5df0d7d78112e5f62a8599bdbc879
2022-06-21 11:06:44 +02:00
Ed Sanders 15bc24205e Update VE core submodule to master (41653c74a)
New changes:
7f80d75ce Context: Move copy/delete buttons to MobileActionsContextItem
2be9610ec Move close button from contextItem to context

Bug: T304233
Change-Id: I49ce23f31afd003cf2dd6a525aeabde6332eb9a1
2022-04-07 00:01:09 +02:00
Bartosz Dziewoński 84de6bdad2 Update VE core submodule to master (2947b78df)
New changes:
3c1ddf0b0 Localisation updates from https://translatewiki.net.
e1d8bdb93 Localisation updates from https://translatewiki.net.
d125de1da Localisation updates from https://translatewiki.net.
ecd7292fc Tweak paragraph margins in multi-line table cells to match view mode

Local changes:
* Add new file to ResourceLoader module

Bug: T295252
Change-Id: Ie8782324cd33f880d3695e57ae2d8715e14fb77d
2021-12-16 17:08:47 +01:00
WMDE-Fisch f9fda0594f Introducing a mixin for ARIA descriptions on parameter selection
Allows setting aria labels and descriptions on elements in a
convinient way. I did not use the the .mixin. convention here for
because there's already another mixin in that folder that's also
not having .mixin. as part of its name. And then there's also no
no need to open up that extra namespace here.

If we move this upstream at some point this can be changed though.

Bug: T291284
Change-Id: I1b3d40400d539f851f13719e16ced200968a7f92
2021-11-01 13:20:00 +01:00
Thiemo Kreuz 0ba7480901 More complete top-level part selection support in new sidebar
This comes with a few significant changes:
* A whole bunch of places in the code that focus and highlight
  an element in the old sidebar consider the new sidebar now.
* Same when e.g. the toolbar at the bottom needs to know which
  part is selected. This is read from the new sidebar now.
* To make this possible I had to merge the small helper class
  we introduced in I7bc73cc back into the dialog.

It's helpful to understand how the event flow works:
* You click a template name. This does nothing (does not select
  the element). It only triggers an event.
* The event is catched by the outer container that manages
  all parts. From there all elements are unselected, and one
  selected. This call is internal and should not trigger
  another event.

Bug: T285323
Bug: T288827
Bug: T289043
Change-Id: I4a2d2b83cf2691423d4b0e6f4487228fa3c7b56d
2021-08-27 19:16:00 +02:00
Thiemo Kreuz 4f9426d61a Rename …ParameterCheckboxLayout now that it's an actual Widget
This is a direct follow-up for Idc5e048.

Bug: T285323
Change-Id: Ia03d594386a9a59a4819bf78c7d2edcd465dfd52
2021-08-20 09:56:40 +02:00
WMDE-Fisch 407ff95597 Rename OutlineParameterCheckboxWidget to OutlineParameterCheckboxLayout
This not really just a checkbox widget anymore it inherits from
FieldLayout and became something more in that direction.

Let's use a mixture of these things to make it a bit clearer.

See also comment in Ie81b84be288553343017c4aaf8691c4e266995f5

Change-Id: Iff1746a8e5e94b56eb6c27465405aaf6b74c2310
2021-06-21 09:08:54 +02:00
jenkins-bot 2a74f10909 Merge "Dismissible feedback message for the template search" 2021-06-16 11:02:50 +00:00
Andrew Kostka 13d1c4d2ac Dismissible feedback message for the template search
Bug: T284742
Change-Id: I5dc32521b899c3c9d35d1bf77d346384e4cc87e6
2021-06-16 10:03:04 +02:00
Adam Wight 44035a2384 Introduce a new class to encapsulate booklet inter-pane wiring
Begin to extract the wiring between a sidebar and the content pane of
the template dialog booklet layout.  Eventually, this helper class
will present a high-level interface like "addPart(id)" and will take
care of creating the outline item, content page, and connecting
events.

Start very simple, take over the "focus" method.

Bug: T284632
Change-Id: I7bc73cc4386b99d95941fc6ed88ab5bd998de014
2021-06-10 15:30:51 +02:00
James D. Forrester cce248ce01 Update VE core submodule to master (0c024f431)
New changes:
5866b762f build: Re-enable Firefox testing
501e8354e ve.dm.Converter: Remove unused branch
84086e60f Localisation updates from https://translatewiki.net.
e1eb88ea2 Unify `list-style` CSS
d8eae968d ve.dm.Converter: Move var declarations inline
a26ff5fa6 ve.ce.Surface: Move var declarations inline
47a2d36f3 Localisation updates from https://translatewiki.net.
cf97b4938 build: Merge eslint main and html tasks back together
381ade44c build: Updating grunt to 1.4.0
d98f7995a Localisation updates from https://translatewiki.net.
c6bc154d2 Check if alien context item is registered before using
e645b06af Localisation updates from https://translatewiki.net.
58830c0dd build: Updating postcss to 8.2.15
f7b193a7e Localisation updates from https://translatewiki.net.
9730bd748 Update OOjs to v6.0.0

Bug: T240955
Bug: T282194
Change-Id: I7a26365a24103ac4e4b1279fda3b74ac6e4a9497
2021-05-17 17:35:37 -07:00
Bartosz Dziewoński 5cd2899196 Update VE core submodule to master (3c56d0611)
New changes:
582ab6eda Localisation updates from https://translatewiki.net.
7eb90ef85 Make client utils a dependency of platform
2f7675785 Remove @abstract from ve.ce.View.getResolvedAttribute
ca3f685b3 ve.createDocumentFromHtml: Do not lose <style> tags in doc fragments

Bug: T273234
Change-Id: I4bced562f018bf4f28e18ca838c8218de68ee519
2021-02-24 23:04:59 +01:00
Ed Sanders ef18cea2c3 Update VE core submodule to master (03532b74d)
New changes:
daf2239a3 Localisation updates from https://translatewiki.net.
0adfcd9b2 Localisation updates from https://translatewiki.net.
21ce76329 FocusableNode: Check for surface after setTimeout
6d615c6a4 build: Remove Gemfile and rubocop files
c58df0121 Localisation updates from https://translatewiki.net.
d5844cec3 Inherit LanguageAnnotation from TextStyleAnnotation
03532b74d Convert <bdo> tags to LanguageAnnotation

Bug: T259632
Bug: T264439
Change-Id: I3a780ec673cc32bf39cfd4a0e2f0ee3bba37327f
2020-10-02 12:48:51 -07:00
James D. Forrester 207c1220a6 Update VE core submodule to master (53af216aa)
New changes:
6eac66f9c Localisation updates from https://translatewiki.net.
805a30e4a ve.dm.Node: Check if attached before accessing document
49d8e2971 Catch exceptions caused by illegal offsets passed to native ranges
25b6c818b Catch errors from getNodeAndOffset in annotationsAtModelSelection
a1b9d6763 jsduck: Add UI classes to Diffing category

Local changes:
Move new upstream Diffing jsduck section into mainline, add our alterations.

Bug: T136780
Bug: T258191
Bug: T259154
Bug: T262303
Bug: T262354
Bug: T262487
Bug: T262758
Change-Id: Ic20dc9f96350f1a08142dc86f06e5e248c724c1e
2020-09-17 14:28:48 +01:00
James D. Forrester b25c8677da Update VE core submodule to master (e571a9e73)
New changes:
897aa19ce eslintrc: Cleanup rule overrides
ab8013136 Localisation updates from https://translatewiki.net.
fc897b699 Cleanup unicorns even in another content branch node
daf17a986 Localisation updates from https://translatewiki.net.
0fa6c4af9 Follow-up daf17a986: build: Unbreak language lists, adding 'lij'
ded34d9b8 rebaser: Enforce no-var

Bug: T250702
Change-Id: Ie80fc58389ce929d21595252a41b50a9c7bf6152
2020-04-27 10:26:18 -07:00
Ed Sanders 788c57a3ea Update VE core submodule to master (cf72879d2)
New changes:
cf72879d2 Show sum/average when selecting multiple numeric cells

Local changes:
Implement number parsing/formatting for table summing

Bug: T247877
Change-Id: I52af622dc8cfe7e77fd7ce88428be092d5b092a2
2020-03-19 12:26:26 -07:00
David Lynch 078fbcf737 Update VE core submodule to master (e1760b7f7)
New changes:
fb4f0a83b Completion framework

Local changes to wire in the completion framework

Bug: T232601
Depends-On: If6aee9df67e7a1234d47c0ba0c2f05ef47e5bd51
Change-Id: I075cac9aa195574c3d416a40bbdc5ec2d64424e2
2020-02-06 12:05:48 -08:00
James D. Forrester 015f796b63 Update VE core submodule to master (3b3dcad84)
New changes:
7017efbce Sanitize HTML on paste

Bug: T239209
Change-Id: I5f59d537d39b64838a222ab0637957429860508f
2019-12-02 17:26:58 -08:00
Ed Sanders b676b2295b Update VE core submodule to master (3fac5f1f2)
New changes:
8cbedc3c8 build: Update linters
a211e9fd8 TargetWidget: Use surface view focus/blur events
57aeb8b38 Separate utilities required for DOM parsing into separate file

Local changes:
* Setup modules for new parsing utils files

Change-Id: Ie4e59650fdb869e7e4148c97cd03d79ce35187dc
2019-10-23 18:34:17 +02:00
Bartosz Dziewoński 0fb7d5efda Update VE core submodule to 962335a40293cf4b1314c0236788f35f080ae877
New changes:
a06204317 Fix TableNode unit test getOffsetFromCoords failure on Firefox
dfe0eb025 Refactor mobile context logic into ve.ui.MobileContext

Local changes:
* Pull through for edit cards refactor

Bug: T227532
Bug: T228767
Change-Id: I6c043e039fbef62a56f475b0dc365e171ab7bf59
2019-07-23 22:13:27 +00:00
Ed Sanders b64cd4ced1 Update VE core submodule to master (213b79783)
New changes:
6cd9ba63f Localisation updates from https://translatewiki.net.
c9cebed32 Update OOUI to v0.33.2
65c66b8a6 Localisation updates from https://translatewiki.net.
8d94ad13f Replace unrendered parts of the view tree with a stub node
213b79783 Basic unit tests for attachedRoot functionality

Bug: T215717
Change-Id: I7bd8106a82e4fa7c912ce9f8d4fab86bfb546702
2019-07-14 15:26:28 +01:00
James D. Forrester 56df3cc4cb Update VE core submodule to master (75510a515)
New changes:
a3d860daf Localisation updates from https://translatewiki.net.
0421bf6f0 Gather annotations from clicked node where possible
2d2491877 Change#squash: Compact multiple transactions into one
dc0e4650e Fix documentation of ve.dm.Change#serialize
a40f8314f Fix contexedAnnotations equality check
ec62ccb34 Use 16px font size on SA mobile demo
57984c072 Update OOUI to v0.33.1

Add lib/ve/src/dm/ve.dm.TransactionSquasher.js to debugScripts.

Bug: T188026
Bug: T226708
Change-Id: I6eb4ab50ef2c6774963f692f600f059662bf0ac3
2019-07-04 00:31:57 +00:00
Ed Sanders b1ac5b74d3 Update VE core submodule to master (06f1ebb8e)
New changes:
06f1ebb8e Local/SessionStorage refactor

Local changes:
* Update for core storage refactor

Depends-On: I3cc1d5adfbce794e8345b7f1090c10fb0d42d150
Change-Id: If855ee33b0993788cc159d8c3acf03070e6a9566
2019-05-29 14:49:53 -07:00
James D. Forrester 0e7e88c43e Update VE core submodule to master (d9ece414a)
New changes:
c0799b060 Source mode performance optimizations
d9ece414a ve.dm.MetaItem: Add removable flag

Bug: T96528
Change-Id: Ifc0d3322c0ab0c0384fd179281cb1ed7f3ff6b31
2019-05-29 12:31:24 -07:00
Ed Sanders a7149cc3ee Update VE core submodule to master (7cd15cfe9)
New changes:
9b162a5da Localisation updates from https://translatewiki.net.
10dbdabf4 Remove valid-jsdoc exceptions for @chainable
a424f804d Make blockquote a non-content branch node

Local changes:
* Update stuff for making blockquote a non-content branch node

Bug: T76426
Change-Id: I95ae25f20d3d102da69bf5ffdff55335f6c07635
2019-04-22 12:39:14 +01:00
Bartosz Dziewoński 73561f7aba ve.init.mw.MobileArticleTarget: Merge in downstream code from MobileFrontend
It will be easier for us to maintain this way. The code I'm moving had
a lot of comments saying that it should be moved here.

See MobileFrontend change Ibe192360bdecab86519de1781f66f90a3441c551.

Bug: T218946
Change-Id: I908e035ec245a9b190f05e64c35dbb29936434de
2019-03-22 18:30:05 +00:00
Ed Sanders e21d4fab3f Update VE core submodule to master (2951e9378)
New changes:
202adf904 [BREAKING CHANGE] Unify FragmentInspector/Dialog behaviour

Local changes:
* Update dialogs to use common actions & FragmentWindow

Change-Id: Ib744b8996db48d1ee58bc873120400566c490e88
2019-02-22 01:13:36 +01:00
James D. Forrester a6d820eb2b Update VE core submodule to master (4398bb868)
New changes:
865754885 Localisation updates from https://translatewiki.net.
9012ed8b3 build: Update eslint-config-wikimedia to 0.10.0
c08badb61 Restore margins on embedded contexts
c2562ac1b Localisation updates from https://translatewiki.net.
2aea280e8 Update OOUI to v0.30.1
abb751b4e build: Upgrade grunt-banana-checker from 0.6.0 to 0.7.0
1281cfbd5 build: Upgrade qunit from 2.8.0 to 2.9.1 to match MediaWiki
4398bb868 jsduck: Stop running jsduck for tests

Change-Id: I491bc135ef3a5eb58823af5b309de586fd17e406
2019-01-11 08:16:28 -08:00
David Chan 0d362040bd Update VE core module to master (469c6340e)
New changes:
6515e03e1 ve.ce.Surface: Rearrange #findBlockSlug test to check other cases
cbfdc8570 Localisation updates from https://translatewiki.net.
708ba0557 Prevent block slugs from overlapping floated elements
3703fd66d Separate the concept of a document node and a root node in CSS

Bug: T211844
Change-Id: Ia86cf9b23e561d3c32601d41c1bc5a9824e9953c
2019-01-06 07:47:17 +08:00
Bartosz Dziewoński 7bcb1ac50c Update VE core submodule to master (f32c0be7c)
New changes:
61992def0 Remove dedicated annotation operation types
c18308313 Move 'enter' and 'f2' keydown handlers to command/trigger code

Bug: T205535
Change-Id: Ibbf578070c820ae63a8b8ab50e6e4520cabfebe6
2018-11-08 13:45:21 +01:00
Bartosz Dziewoński 9e47873a65 Update VE core submodule to master (236effcd7)
New changes:
0e923fe1b Use initClass in test class
900962720 Add ve.deepFreeze for detecting inadvertent data modification during testing
0761cd90c Localisation updates from https://translatewiki.net.
0e44545b7 Update .gitignore
82b6b80bb Use consistent method for finding nearest cursor offset
0b604de30 ve.ce.TableArrowKeyDownHandler.test: Remove eww gross FIXME

Bug: T202359
Change-Id: I73c46edfbf66a0c76bc719010c017ef71670931b
2018-10-30 00:50:37 +01:00
Bartosz Dziewoński ac45e919ab Update VE core submodule to master (d89186159)
New changes:
d89186159 Add F2 keydown handler

Bug: T172042
Change-Id: I3bc2bb33bec2f5f08f26af49ab8b72e436dbe4cf
2018-10-24 20:51:36 +02:00
James D. Forrester 63bb1354c8 Update VE core submodule to master (474034ad8)
New changes:
01729d1ec Localisation updates from https://translatewiki.net.
c33dc3b44 Asynchronous document store
70ee7c343 Tracking: various annotation and dialog actions

Bug: T202656
Change-Id: I99add8d3a1a9ecf9eaa70522dd49d3c64909a34c
2018-10-16 18:39:40 -07:00
Bartosz Dziewoński e354092417 Update VE core submodule to master (f9afaa3e4)
New changes:
3931cc33a Update OOUI to v0.29.1
5bcab0073 Move node-specific code into rebaser/
8aa80d88b Remove ES6 support for async/await
2536870f9 Separate files for protocol and transport server
b443b7a4f Update OOUI to v0.29.2
70b3ec210 Minor cleanup of ve.ui.MediaSizeWidget

Bug: T206236
Change-Id: Id3bbcd1a9ccb1563e4feb3572aa8f51932677693
2018-10-09 11:06:23 +01:00
Ed Sanders 1631a35c18 Update VE core submodule to master (2d668bdbb)
New changes:
2d668bdbb Separate node classes into individual files

Bug: T205231
Change-Id: Ib628149732e40b139876404867253d0ffa1fb0d0
2018-09-24 08:27:23 -07:00
James D. Forrester a70051d75e Update VE core submodule to master (7c9ceb939)
New changes:
bdd52111a Collapse this.getSurface().getView() to this in ve.ce.Surface
012f77c87 Localisation updates from https://translatewiki.net.
c40692bf5 Use rooms instead of namespaces
31360982e Fix author list when reconnecting
c176f8bba Remove $.isPlainObject warning
ad9edb87a Separate core module into model/view/ui
4475785d5 Merge author name/color data, make naming consistent
8601509c4 Move whitespaceHtmlCharacters to ve.utils.js and rename
361e5d646 Call parent in DimensionsWidget#setDisabled
3a53ca899 Update eslint-plugin-html to 4.0.6
5f88a02bc Allow '/' in path
2ad8dc94d Separate out client-specific utils from ve.utils.js
e8eb8dc97 Fix ve.sanitize to only depend on utils
cdcd7f19b Update UnicodeJS to v0.2.2
689baa436 Report html indent errors
d613e9d48 Create get/setSessionObject methods for JSON storage

Bug: T195111
Bug: T205096
Bug: T205123
Change-Id: Ia519138734ca0c174c20fec2d42f1437c903b82d
2018-09-23 13:53:29 -07:00