wikimedia/mediawiki-extensions-VisualEditor
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor synced 2024-12-23 19:43:19 +00:00
Code Issues Packages Projects Releases Wiki Activity

EditCheck: Only pause if check is not rejected

Browse source 
The pause is to show the user the result of their
action (sepcifically it was designed for AddReferenceEditCheck
to let them see the reference in the page).

If they reject, there is no need to pause. This applies
to mulit-check too where it would cause a pause before moving on
to the next check.

Change-Id: I57f881b37051cc2e5ea6bda23fea66a2de2b342d
This commit is contained in:
Ed Sanders 2024-12-12 12:54:57 +00:00
parent 81197ac662
commit fccb247285
1 changed files with 7 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
editcheck/modules/EditCheckDialog.js
View file

@ -323,13 +323,17 @@ ve.ui.EditCheckDialog.prototype.onAct = function ( widget, choice, actionChosen,
} }
if ( this.listener === 'onBeforeSave' ) { if ( this.listener === 'onBeforeSave' ) {
// We must have been acting on the currentOffset // If an action has been taken, we want to linger for a brief moment
// to show the result of the action before moving away
// TODO: This was written for AddReferenceEditCheck but should be
// more generic
const pause = data.action !== 'reject' ? 500 : 0;
setTimeout( () => { setTimeout( () => {
// We want to linger for a brief moment before moving away // We must have been acting on the currentOffset
this.currentChecks.splice( this.currentOffset, 1 ); this.currentChecks.splice( this.currentOffset, 1 );
this.currentOffset = Math.max( 0, this.currentOffset - 1 ); this.currentOffset = Math.max( 0, this.currentOffset - 1 );
this.update(); this.update();
}, 500 ); }, pause );
} }
} ); } );
}; };