wikimedia/mediawiki-extensions-VisualEditor
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor synced 2024-12-01 09:26:37 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge "Check values property exists before removing attribute"

Browse source
This commit is contained in:
jenkins-bot 2013-12-13 19:39:42 +00:00 committed by Gerrit Code Review
parent 9e9243e51f 74277cbde0
commit fc3ea799df
1 changed files with 5 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
modules/ve/dm/ve.dm.Model.js
View file

@ -279,9 +279,11 @@ ve.dm.Model.static.removeHtmlAttribute = function ( dataElement, attribute ) {
function removeAttributeRecursive( children ) { function removeAttributeRecursive( children ) {
var i; var i;
for ( i = 0; i < children.length; i++ ) { for ( i = 0; i < children.length; i++ ) {
delete children[i].values[attribute]; if ( children[i].values ) {
if ( ve.isEmptyObject( children[i].values ) ) { delete children[i].values[attribute];
delete children[i].values; if ( ve.isEmptyObject( children[i].values ) ) {
delete children[i].values;
}
} }
if ( children[i].children ) { if ( children[i].children ) {
removeAttributeRecursive( children[i].children ); removeAttributeRecursive( children[i].children );