wikimedia/mediawiki-extensions-VisualEditor
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor synced 2024-11-24 22:35:41 +00:00
Code Issues Packages Projects Releases Wiki Activity

Use new isVisible method

Browse source 
Also make sure only one icon is appended in the case where
$element consists of multiple siblings.

Depends on I7b4d9a54c in core.

Change-Id: I5a7985b7a2c709f079afcdfd5108d73cc7bfc688
This commit is contained in:
Ed Sanders 2015-03-30 19:06:54 +01:00 committed by James D. Forrester
parent 9766ea22e6
commit f86b8aef74
1 changed files with 2 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
modules/ve-mw/ce/nodes/ve.ce.MWTransclusionNode.js
View file

@ -82,19 +82,12 @@ ve.ce.MWTransclusionNode.prototype.onSetup = function () {
// Parent method
ve.ce.MWTransclusionNode.super.prototype.onSetup.call( this );
if (
this.$element.text().trim().length === 0 &&
// Check whether the element is too small to comfortably select
(
this.$element.width() < 8 ||
this.$element.height() < 8
)
) {
if ( !this.isVisible() ) {
// We have to reset the icon when it is reappended, because
// setIcon also affects the classes attached to this.$element
this.setIcon( 'template' );
// Reattach icon
this.$element.prepend( this.$icon );
this.$element.first().prepend( this.$icon );
} else {
// We have to clear the icon because if the icon's symbolic name
// has not changed since the last time we rendered, this.setIcon()