wikimedia/mediawiki-extensions-VisualEditor
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor synced 2024-09-25 19:26:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

ve.Element: Fallback to body, window is not scrollable

Browse source 
Bug: 54928
Change-Id: Ifec0dae598f7fd99270588bd8ca77777a07e9669
This commit is contained in:
Timo Tijhof 2013-10-03 22:37:23 +02:00
parent dd9511f249
commit f6d409e09b
1 changed files with 6 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
modules/ve/ve.Element.js
View file

@ -256,9 +256,9 @@ ve.Element.getClosestScrollableContainer = function ( el, dimension ) {
props.push( 'overflow-' + dimension );
}
while ( $parent ) {
if ( $parent[0] === el.ownerDocument.documentElement ) {
break;
while ( $parent.length ) {
if ( $parent[0] === el.ownerDocument.body ) {
return $parent[0];
}
i = props.length;
while ( i-- ) {
@ -269,7 +269,7 @@ ve.Element.getClosestScrollableContainer = function ( el, dimension ) {
}
$parent = $parent.parent();
}
return this.getWindow( el );
return this.getDocument( el ).body;
};
/**
@ -277,7 +277,7 @@ ve.Element.getClosestScrollableContainer = function ( el, dimension ) {
*
* @static
* @param {HTMLElement} el Element to scroll into view
* @param {Object} [config] Configuration config
* @param {Object} [config={}] Configuration config
* @param {string} [config.duration] jQuery animation duration value
* @param {string} [config.direction] Scroll in only one direction, e.g. 'x' or 'y', omit
* to scroll in both directions
@ -375,6 +375,7 @@ ve.Element.prototype.getClosestScrollableElementContainer = function () {
*
* @method
* @see #static-method-scrollIntoView
* @param {Object} [config={}]
*/
ve.Element.prototype.scrollElementIntoView = function ( config ) {
return ve.Element.scrollIntoView( this.$[0], config );