From f6526cb0a91ab162ef73962ac13d7fff7c788fdd Mon Sep 17 00:00:00 2001 From: Cmcmahon Date: Fri, 21 Nov 2014 09:49:50 -0700 Subject: [PATCH] [BrowserTest] comments for classes Change-Id: I3d5e063ee4dd36632ab9c2a433660567b70777ea --- .rubocop_todo.yml | 4 ---- .../tests/browser/features/support/pages/dummy_page.rb | 1 + .../tests/browser/features/support/pages/user_page.rb | 8 -------- .../browser/features/support/pages/visual_editor_page.rb | 1 + .../tests/browser/features/support/pages/zarticlepage.rb | 1 + 5 files changed, 3 insertions(+), 12 deletions(-) delete mode 100644 modules/ve-mw/tests/browser/features/support/pages/user_page.rb diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index cf265f1918..a45077fe69 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -27,10 +27,6 @@ Metrics/LineLength: Metrics/MethodLength: Max: 18 -# Offense count: 4 -Style/Documentation: - Enabled: false - # Offense count: 3 # Configuration parameters: AllowedVariables. Style/GlobalVars: diff --git a/modules/ve-mw/tests/browser/features/support/pages/dummy_page.rb b/modules/ve-mw/tests/browser/features/support/pages/dummy_page.rb index 11f099acb1..54e4cddf4b 100644 --- a/modules/ve-mw/tests/browser/features/support/pages/dummy_page.rb +++ b/modules/ve-mw/tests/browser/features/support/pages/dummy_page.rb @@ -1,3 +1,4 @@ +# This is used in the verify_production_wikis test class DummyPage include PageObject diff --git a/modules/ve-mw/tests/browser/features/support/pages/user_page.rb b/modules/ve-mw/tests/browser/features/support/pages/user_page.rb deleted file mode 100644 index a7c80be052..0000000000 --- a/modules/ve-mw/tests/browser/features/support/pages/user_page.rb +++ /dev/null @@ -1,8 +0,0 @@ -class UserPage - include PageObject - - include URL - page_url URL.url('<%=params[:page_title]%>') - - div(:ve_editing_surface, class: 've-ui-surface ve-init-mw-viewPageTarget-surface') -end diff --git a/modules/ve-mw/tests/browser/features/support/pages/visual_editor_page.rb b/modules/ve-mw/tests/browser/features/support/pages/visual_editor_page.rb index 9b08946db5..b0b2b97976 100644 --- a/modules/ve-mw/tests/browser/features/support/pages/visual_editor_page.rb +++ b/modules/ve-mw/tests/browser/features/support/pages/visual_editor_page.rb @@ -1,3 +1,4 @@ +# This is the main page for VisualEditor class VisualEditorPage include PageObject include URL diff --git a/modules/ve-mw/tests/browser/features/support/pages/zarticlepage.rb b/modules/ve-mw/tests/browser/features/support/pages/zarticlepage.rb index ed379ffeb4..732dd2dacf 100644 --- a/modules/ve-mw/tests/browser/features/support/pages/zarticlepage.rb +++ b/modules/ve-mw/tests/browser/features/support/pages/zarticlepage.rb @@ -1,3 +1,4 @@ +# This page object exists because logged in users should not see these URL params class ZtargetPage < VisualEditorPage include URL page_url URL.url('<%=params[:article_name]%>?vehidebetadialog=true&veaction=edit')