wikimedia/mediawiki-extensions-VisualEditor
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor synced 2024-11-24 22:35:41 +00:00
Code Issues Packages Projects Releases Wiki Activity

Disable inserting/changing references when surface widget is empty

Browse source 
This listens to change events on the surface and checks to see if
there is more than just an empty paragraph node.

Bug: 53345
Change-Id: Ic8fa84d7cdcbffd154178939d0ec8c2c4f86c415
This commit is contained in:
Ed Sanders 2013-08-27 16:29:55 -07:00
parent 92c7be9b31
commit f50102f521
2 changed files with 18 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
modules/ve-mw/ui/dialogs/ve.ui.MWReferenceDialog.js
View file

@ -342,6 +342,9 @@ ve.ui.MWReferenceDialog.prototype.useReference = function ( ref ) {
} }
); );
// Event handlers
this.referenceSurface.getSurface().getModel().connect( this, { 'change': 'onSurfaceChange' } );
// Initialization // Initialization
this.referenceGroupInput.setValue( refGroup ); this.referenceGroupInput.setValue( refGroup );
this.contentFieldset.$.append( this.referenceSurface.$ ); this.contentFieldset.$.append( this.referenceSurface.$ );
@ -350,6 +353,18 @@ ve.ui.MWReferenceDialog.prototype.useReference = function ( ref ) {
return this; return this;
}; };
/**
* Handle reference surface change events
*/
ve.ui.MWReferenceDialog.prototype.onSurfaceChange = function () {
var data = this.referenceSurface.getContent(),
// TODO: Check for other types of empty, e.g. only whitespace?
disabled = data.length <= 2;
this.insertButton.setDisabled( disabled );
this.applyButton.setDisabled( disabled );
};
/* Registration */ /* Registration */
ve.ui.dialogFactory.register( 'mwReference', ve.ui.MWReferenceDialog ); ve.ui.dialogFactory.register( 'mwReference', ve.ui.MWReferenceDialog );

6
modules/ve/ui/ve.ui.Widget.js
View file

@ -59,11 +59,11 @@ ve.ui.Widget.prototype.isDisabled = function () {
* This should probably change the widgets's appearance and prevent it from being used. * This should probably change the widgets's appearance and prevent it from being used.
* *
* @method * @method
* @param {boolean} state Disable button * @param {boolean} disabled Disable button
* @chainable * @chainable
*/ */
ve.ui.Widget.prototype.setDisabled = function ( state ) { ve.ui.Widget.prototype.setDisabled = function ( disabled ) {
this.disabled = !!state; this.disabled = !!disabled;
if ( this.disabled ) { if ( this.disabled ) {
this.$.addClass( 've-ui-widget-disabled' ); this.$.addClass( 've-ui-widget-disabled' );
} else { } else {