wikimedia/mediawiki-extensions-VisualEditor
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor synced 2024-09-25 19:26:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

Use correct OOUI hierarchy in gallery dialog

Browse source 
Make sure fieldset layouts contain field layouts. Also remove
meaningless parameter icons.

Bug: T205615
Change-Id: Ia104cd60ffa9f5d636bee5611f265a2bb5ac0051
This commit is contained in:
Thalia 2018-10-03 22:16:43 +01:00
parent 542004dcb9
commit f422ae2dcc
1 changed files with 13 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

21
modules/ve-mw/ui/dialogs/ve.ui.MWGalleryDialog.js
View file

@ -129,7 +129,8 @@ ve.ui.MWGalleryDialog.prototype.initialize = function () {
innerMenuLayout, innerMenuPanel, innerContentPanel,
modeField, captionField, widthsField, heightsField,
perrowField, showFilenameField, classesField, stylesField,
highlightedCaptionFieldset, highlightedAltTextFieldset;
highlightedCaptionField, highlightedCaptionFieldset,
highlightedAltTextField, highlightedAltTextFieldset;
// Parent method
ve.ui.MWGalleryDialog.super.prototype.initialize.call( this );
@ -227,17 +228,21 @@ ve.ui.MWGalleryDialog.prototype.initialize = function () {
classes: [ 've-ui-mwGalleryDialog-remove-button' ]
} );
highlightedCaptionField = new OO.ui.FieldLayout( this.highlightedCaptionTarget, {
align: 'top'
} );
highlightedCaptionFieldset = new OO.ui.FieldsetLayout( {
label: ve.msg( 'visualeditor-dialog-media-content-section' ),
icon: 'parameter'
label: ve.msg( 'visualeditor-dialog-media-content-section' )
} );
highlightedCaptionFieldset.$element.append( this.highlightedCaptionTarget.$element );
highlightedCaptionFieldset.addItems( highlightedCaptionField );
highlightedAltTextFieldset = new OO.ui.FieldsetLayout( {
label: ve.msg( 'visualeditor-dialog-media-alttext-section' ),
icon: 'parameter'
highlightedAltTextField = new OO.ui.FieldLayout( this.highlightedAltTextInput, {
align: 'top'
} );
highlightedAltTextFieldset.$element.append( this.highlightedAltTextInput.$element );
highlightedAltTextFieldset = new OO.ui.FieldsetLayout( {
label: ve.msg( 'visualeditor-dialog-media-alttext-section' )
} );
highlightedAltTextFieldset.addItems( highlightedAltTextField );
// Search panel
this.searchWidget = new mw.widgets.MediaSearchWidget( {