From e59ee87887529985dac800e090a530cde68d3807 Mon Sep 17 00:00:00 2001 From: Ed Sanders Date: Sun, 23 Aug 2015 20:04:00 +0100 Subject: [PATCH] Add spacer above basic reference option Also add classes to basic/reuse so they can be differently styled. Bug: T108725 Change-Id: I4d128afe86c7fae2d8cbd8a57749970942e39e76 --- VisualEditor.hooks.php | 1 + .../widgets/ve.ui.MWReferenceSourceSelectWidget.css | 10 ++++++++++ .../ui/widgets/ve.ui.MWReferenceSourceSelectWidget.js | 10 ++++++++-- 3 files changed, 19 insertions(+), 2 deletions(-) create mode 100644 modules/ve-mw/ui/styles/widgets/ve.ui.MWReferenceSourceSelectWidget.css diff --git a/VisualEditor.hooks.php b/VisualEditor.hooks.php index 1a795077bb..a2536ea409 100644 --- a/VisualEditor.hooks.php +++ b/VisualEditor.hooks.php @@ -495,6 +495,7 @@ class VisualEditorHooks { 'modules/ve-mw/ui/styles/widgets/ve.ui.MWReferenceGroupInputWidget.css', 'modules/ve-mw/ui/styles/widgets/ve.ui.MWReferenceResultWidget.css', 'modules/ve-mw/ui/styles/widgets/ve.ui.MWReferenceSearchWidget.css', + 'modules/ve-mw/ui/styles/widgets/ve.ui.MWReferenceSourceSelectWidget.css', ), 'dependencies' => array( 'ext.visualEditor.mwreference.core', diff --git a/modules/ve-mw/ui/styles/widgets/ve.ui.MWReferenceSourceSelectWidget.css b/modules/ve-mw/ui/styles/widgets/ve.ui.MWReferenceSourceSelectWidget.css new file mode 100644 index 0000000000..4beaa187b6 --- /dev/null +++ b/modules/ve-mw/ui/styles/widgets/ve.ui.MWReferenceSourceSelectWidget.css @@ -0,0 +1,10 @@ +/*! + * VisualEditor MediaWiki UserInterface MWReferenceSearchWidget styles. + * + * @copyright 2011-2015 VisualEditor Team and others; see AUTHORS.txt + * @license The MIT License (MIT); see LICENSE.txt + */ + +.ve-ui-mwReferenceSourceSelectWidget-separator { + border-top: 1px solid #ccc; +} diff --git a/modules/ve-mw/ui/widgets/ve.ui.MWReferenceSourceSelectWidget.js b/modules/ve-mw/ui/widgets/ve.ui.MWReferenceSourceSelectWidget.js index fdf9bf672e..a615211f98 100644 --- a/modules/ve-mw/ui/widgets/ve.ui.MWReferenceSourceSelectWidget.js +++ b/modules/ve-mw/ui/widgets/ve.ui.MWReferenceSourceSelectWidget.js @@ -50,7 +50,8 @@ ve.ui.MWReferenceSourceSelectWidget = function VeUiMWReferenceSourceSelectWidget this.refBasic = new OO.ui.DecoratedOptionWidget( { icon: 'reference', label: ve.msg( 'visualeditor-dialogbutton-reference-full-label' ), - data: { windowName: 'reference' } + data: { windowName: 'reference' }, + classes: [ 've-ui-mwReferenceSourceSelectWidget-basic' ] } ); items.push( this.refBasic ); @@ -61,13 +62,18 @@ ve.ui.MWReferenceSourceSelectWidget = function VeUiMWReferenceSourceSelectWidget data: { windowName: 'reference', dialogData: { useExisting: true } - } + }, + classes: [ 've-ui-mwReferenceSourceSelectWidget-reuse' ] } ); items.push( this.refExisting ); } this.addItems( items ); + $( '
' ) + .addClass( 've-ui-mwReferenceSourceSelectWidget-separator' ) + .insertBefore( this.refBasic.$element ); + // Initialization this.$element.addClass( 've-ui-mwReferenceSourceSelectWidget' ); };