From f2875141d8035dd3662f7c19e3c467df60e6c3fc Mon Sep 17 00:00:00 2001 From: Timo Tijhof Date: Tue, 2 Jun 2015 02:00:48 +0100 Subject: [PATCH] ve.dm.MWTemplateSpecModel: Account for data.maps being undefined This new property is optional and should not be assumed to be present. Follows-up 2ac7959849. The constructor defaults 'maps' to an empty object, so there's no need to add a "|| {}" in extend() or getMaps(). We merely need to make sure we don't accidentally dereference the default in exchange for undefined. Change-Id: Id2cb93696d12a20ee14f9d59705877dc174e6564 --- modules/ve-mw/dm/models/ve.dm.MWTemplateSpecModel.js | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/modules/ve-mw/dm/models/ve.dm.MWTemplateSpecModel.js b/modules/ve-mw/dm/models/ve.dm.MWTemplateSpecModel.js index 91c8edc3fc..d68fbbab08 100644 --- a/modules/ve-mw/dm/models/ve.dm.MWTemplateSpecModel.js +++ b/modules/ve-mw/dm/models/ve.dm.MWTemplateSpecModel.js @@ -71,7 +71,9 @@ ve.dm.MWTemplateSpecModel.prototype.extend = function ( data ) { } } this.sets = data.sets; - this.maps = data.maps; + if ( data.maps ) { + this.maps = data.maps; + } }; /**