wikimedia/mediawiki-extensions-VisualEditor
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor synced 2024-11-29 08:34:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

Return undefined, not null from onbeforeunload

Browse source 
IE doesn't accept null as a "do nothing" value, only undefined.
If you return null, it'll show a popup with the text "null".

Change-Id: I984a7ded483c4c178cbca2a9af9abd895e6ded56
This commit is contained in:
Roan Kattouw 2014-08-28 14:38:49 -07:00
parent a9b01bdc8d
commit f0cadeca42
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.js
View file

@ -1618,7 +1618,7 @@ ve.init.mw.ViewPageTarget.prototype.saveEditSection = function ( heading ) {
}; };
/** /**
* Add onbeforunload handler. * Add onbeforeunload handler.
* *
* @method * @method
*/ */
@ -1726,7 +1726,7 @@ ve.init.mw.ViewPageTarget.prototype.onBeforeUnload = function () {
} else { } else {
// Override if submitting // Override if submitting
if ( this.submitting ) { if ( this.submitting ) {
return null; return undefined;
} }
// Check if there's been an edit // Check if there's been an edit
if ( this.surface && this.edited && mw.user.options.get( 'useeditwarning' ) ) { if ( this.surface && this.edited && mw.user.options.get( 'useeditwarning' ) ) {