wikimedia/mediawiki-extensions-VisualEditor
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor synced 2024-11-28 08:10:35 +00:00
Code Issues Packages Projects Releases Wiki Activity

Rewrite DOM junk filter as array concatenation

Browse source 
Avoids regressions like If399319b2675ac8c.

Change-Id: I43851931e3b9ee461abd0cfce0627bfb6a2bd041
This commit is contained in:
Ed Sanders 2018-12-11 15:23:37 +00:00
parent 27fdbe0581
commit ec42733225
1 changed files with 14 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

28
modules/ve-mw/init/ve.init.mw.Target.js
View file

@ -259,21 +259,21 @@ ve.init.mw.Target.prototype.getHtml = function ( newDoc, oldDoc ) {
// Filter out junk that may have been added by browser plugins // Filter out junk that may have been added by browser plugins
$( newDoc ) $( newDoc )
.find( .find( [
'script, ' + // T54884, T65229, T96533, T103430 'script', // T54884, T65229, T96533, T103430
'noscript, ' + // T144891 'noscript', // T144891
'object, ' + // T65229 'object', // T65229
'style:not( [ data-mw ] ), ' + // T55252, but allow <style data-mw/> e.g. TemplateStyles T188143 'style:not( [ data-mw ] )', // T55252, but allow <style data-mw/> e.g. TemplateStyles T188143
'embed, ' + // T53521, T54791, T65121 'embed', // T53521, T54791, T65121
'a[href^="javascript:"], ' + // T200971 'a[href^="javascript:"]', // T200971
'img[src^="data:"], ' + // T192392 'img[src^="data:"]', // T192392
'div[id="myEventWatcherDiv"], ' + // T53423 'div[id="myEventWatcherDiv"]', // T53423
'div[id="sendToInstapaperResults"], ' + // T63776 'div[id="sendToInstapaperResults"]', // T63776
'div[id="kloutify"], ' + // T69006 'div[id="kloutify"]', // T69006
'div[id^="mittoHidden"], ' + // T70900 'div[id^="mittoHidden"]', // T70900
'div.hon.certificateLink, ' + // HON (T209619) 'div.hon.certificateLink', // HON (T209619)
'div.donut-container' // Web of Trust (T189148) 'div.donut-container' // Web of Trust (T189148)
) ].join( ',' ) )
.remove(); .remove();
// Add doctype manually // Add doctype manually
return '<!doctype html>' + ve.serializeXhtml( newDoc ); return '<!doctype html>' + ve.serializeXhtml( newDoc );