From eb8aede95fad5644f6575ea18ece31650b1dc8b4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bartosz=20Dziewo=C5=84ski?= Date: Tue, 14 May 2019 02:50:19 +0200 Subject: [PATCH] MobileArticleTarget: Update loading interface for new design * Remove animation for toolbar sliding into place. It now happens on the fake toolbar in MobileFrontend shown before the real toolbar loads, and our toolbar just transparently replaces it. Bug: T217784 Depends-On: If21aa0ea619ec2500ce5fca6fe81eb27f26bb047 Change-Id: Ib6ff7594e1982d1b46e9ca89d6b9722d025e8207 --- .../init/targets/ve.init.mw.MobileArticleTarget.js | 14 -------------- 1 file changed, 14 deletions(-) diff --git a/modules/ve-mw/init/targets/ve.init.mw.MobileArticleTarget.js b/modules/ve-mw/init/targets/ve.init.mw.MobileArticleTarget.js index bd8b3b481a..1356f1f513 100644 --- a/modules/ve-mw/init/targets/ve.init.mw.MobileArticleTarget.js +++ b/modules/ve-mw/init/targets/ve.init.mw.MobileArticleTarget.js @@ -482,8 +482,6 @@ ve.init.mw.MobileArticleTarget.prototype.load = function () { * @inheritdoc */ ve.init.mw.MobileArticleTarget.prototype.setupToolbar = function ( surface ) { - var $header = this.overlay.$el.find( '.overlay-header-container' ); - if ( !this.pageToolbar ) { this.pageToolbar = new ve.ui.TargetToolbar( this, { actions: true } ); } @@ -547,18 +545,6 @@ ve.init.mw.MobileArticleTarget.prototype.setupToolbar = function ( surface ) { // Append the context to the toolbar this.toolbar.$bar.append( surface.getContext().$element ); - // Animate the toolbar sliding into place. - // Do not animate if we're replacing the wikitext editor toolbar. - if ( !this.overlay.options.switched ) { - $header.addClass( 'toolbar-hidden' ); - setTimeout( function () { - $header.addClass( 'toolbar-shown' ); - setTimeout( function () { - $header.addClass( 'toolbar-shown-done' ); - }, 250 ); - } ); - } - // Don't wait for the first surface focus/blur event to hide one of the toolbars this.onSurfaceBlur(); };