wikimedia/mediawiki-extensions-VisualEditor
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor synced 2024-11-15 10:35:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge "Defend against empty file pages in media dialog search"

Browse source
This commit is contained in:
jenkins-bot 2015-02-12 17:01:23 +00:00 committed by Gerrit Code Review
parent a65148d69e 65d0a9d7e7
commit eaddd87020
1 changed files with 8 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
modules/ve-mw/dm/models/ve.dm.MWMediaResourceProvider.js
View file

@ -190,6 +190,14 @@ ve.dm.MWMediaResourceProvider.prototype.fetchAPIresults = function ( howMany ) {
if ( raw ) {
// Strip away the page ids
for ( page in raw ) {
if ( !raw[page].imageinfo ) {
// The search may give us pages that belong to the File:
// namespace but have no files in them, either because
// they were deleted or imported wrongly, or just started
// as pages. In that case, the response will not include
// imageinfo. Skip those files.
continue;
}
newObj = raw[page].imageinfo[0];
newObj.title = raw[page].title;
results.push( newObj );