wikimedia/mediawiki-extensions-VisualEditor
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor synced 2024-11-15 02:23:58 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix term in valuable data test

Browse source 
We want to assert that value is true-ish, and that it doesn't equal a
default or auto string.

Bug: T290554
Change-Id: I454dda8d0085a8d3898a0d5b1a3ecc6dd7c2c9e4
This commit is contained in:
Adam Wight 2021-09-08 15:46:36 +02:00 committed by Awight
parent aa0a3fb081
commit ea8b90b015
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
modules/ve-mw/dm/models/ve.dm.MWTemplateModel.js
View file

@ -386,7 +386,7 @@ ve.dm.MWTemplateModel.prototype.containsValuableData = function () {
var param = params[ name ],
value = param.getValue();
return !value &&
return value &&
// This will automatically be restored, see {@see ve.dm.MWParameterModel.getValue}
value !== param.getAutoValue() &&
// While this isn't always meaningless, it typically is, and it's easy to restore