wikimedia/mediawiki-extensions-VisualEditor
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor synced 2024-09-25 11:16:51 +00:00
Code Issues Packages Projects Releases Wiki Activity

ve.init.mw.MobileArticleTarget: Remove error handling hacks for MobileFrontend

Browse source 
As of commit c65ed0e7a8ac5f32a3a6e4cb2760dae03e4fca22 in MobileFrontend,
it uses errorformat=html queries (the same as we do), so we no longer
need to massage the responses to make it happy. The same commit also
turned parseSaveError() into a no-op, so we can remove that as well.

Change-Id: I4f0109ce120ebf94e5709d47d775a8178ce216fa
This commit is contained in:
Bartosz Dziewoński 2019-10-21 20:25:56 +02:00
parent 618225d4ed
commit e82f5ccf02
1 changed files with 1 additions and 15 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
modules/ve-mw/init/targets/ve.init.mw.MobileArticleTarget.js
View file

@ -75,15 +75,6 @@ ve.init.mw.MobileArticleTarget.static.trackingName = 'mobile';
// FIXME Some of these users will be on tablets, check for this
ve.init.mw.MobileArticleTarget.static.platformType = 'phone';
/* Static Methods */
// FIXME This method is overridden in the MobileFrontend extension,
// figure out a way to make it public there so that we can use it here
/**
* @method
*/
ve.init.mw.MobileArticleTarget.static.parseSaveError = null;
/* Methods */
/**
@ -454,12 +445,7 @@ ve.init.mw.MobileArticleTarget.prototype.saveFail = function ( doc, saveData, wa
// parent method
ve.init.mw.MobileArticleTarget.super.prototype.saveFail.apply( this, arguments );
// Massage errorformat=html responses to look more like errorformat=bc expected by MF
if ( data.errors ) {
data.error = data.errors[ 0 ];
}
this.overlay.onSaveFailure( this.constructor.static.parseSaveError( data, status ) );
this.overlay.onSaveFailure( data );
};
/**