wikimedia/mediawiki-extensions-VisualEditor
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor synced 2024-12-18 01:00:45 +00:00
Code Issues Packages Projects Releases Wiki Activity

.eslintrc: Enable and fix "max-statements-per-line": 1

Browse source 
I am surprised this was disabled. I investigated this after reviewing
some code by a new contributor which I was certain should have failed
the lint check, but passed.

Change-Id: I5b3c837b8ca3292f6e268b3922443bd9587eadbe
This commit is contained in:
Bartosz Dziewoński 2018-10-30 00:19:16 +01:00
parent 4e539c8e3d
commit e7fd1ac847
5 changed files with 26 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
.eslintrc.json
View file

@ -16,6 +16,7 @@
}, },
"rules": { "rules": {
"dot-notation": [ "error", { "allowKeywords": true } ], "dot-notation": [ "error", { "allowKeywords": true } ],
"max-statements-per-line": [ "error", { "max": 1 } ],
"max-len": 0, "max-len": 0,
"valid-jsdoc": 0 "valid-jsdoc": 0
} }

20
modules/ve-mw/dm/nodes/ve.dm.MWLanguageVariantNode.js
View file

@ -359,10 +359,20 @@ ve.dm.MWLanguageVariantNode.prototype.getRuleType = function () {
* @return {string} * @return {string}
*/ */
ve.dm.MWLanguageVariantNode.static.getRuleType = function ( variantInfo ) { ve.dm.MWLanguageVariantNode.static.getRuleType = function ( variantInfo ) {
if ( variantInfo.disabled ) { return 'disabled'; } if ( variantInfo.disabled ) {
if ( variantInfo.filter ) { return 'filter'; } return 'disabled';
if ( variantInfo.name ) { return 'name'; } }
if ( variantInfo.twoway ) { return 'twoway'; } if ( variantInfo.filter ) {
if ( variantInfo.oneway ) { return 'oneway'; } return 'filter';
}
if ( variantInfo.name ) {
return 'name';
}
if ( variantInfo.twoway ) {
return 'twoway';
}
if ( variantInfo.oneway ) {
return 'oneway';
}
return 'unknown'; // should never happen return 'unknown'; // should never happen
}; };

4
modules/ve-mw/tests/ce/ve.ce.Surface.test.js
View file

@ -60,7 +60,9 @@ QUnit.test( 'handleLinearDelete', function ( assert ) {
} ); } );
} ); } );
promise.finally( function () { done(); } ); promise.finally( function () {
done();
} );
} ); } );
QUnit.test( 'beforePaste/afterPaste', function ( assert ) { QUnit.test( 'beforePaste/afterPaste', function ( assert ) {

4
modules/ve-mw/tests/ve.test.utils.js
View file

@ -25,7 +25,9 @@
this.imageInfoCache = null; this.imageInfoCache = null;
} }
OO.inheritClass( MWDummyPlatform, ve.init.mw.Platform ); OO.inheritClass( MWDummyPlatform, ve.init.mw.Platform );
MWDummyPlatform.prototype.getMessage = function () { return Array.prototype.join.call( arguments, ',' ); }; MWDummyPlatform.prototype.getMessage = function () {
return Array.prototype.join.call( arguments, ',' );
};
MWDummyPlatform.prototype.getHtmlMessage = function () { MWDummyPlatform.prototype.getHtmlMessage = function () {
var $wrapper = $( '<div>' ); var $wrapper = $( '<div>' );
Array.prototype.forEach.call( arguments, function ( arg, i, args ) { Array.prototype.forEach.call( arguments, function ( arg, i, args ) {

6
modules/ve-mw/ui/inspectors/ve.ui.MWLanguageVariantInspector.js
View file

@ -595,7 +595,8 @@ ve.ui.MWLanguageVariantTwoWayInspector.prototype.getDefaultVariantInfo = functio
ve.ui.MWLanguageVariantTwoWayInspector.prototype.getSetupProcess = function ( data ) { ve.ui.MWLanguageVariantTwoWayInspector.prototype.getSetupProcess = function ( data ) {
return ve.ui.MWLanguageVariantTwoWayInspector.super.prototype.getSetupProcess.call( this, data ).next( function () { return ve.ui.MWLanguageVariantTwoWayInspector.super.prototype.getSetupProcess.call( this, data ).next( function () {
var variantInfo = this.variantNode.getVariantInfo(); var variantInfo = this.variantNode.getVariantInfo();
this.layout.clearItems(); this.items = []; this.layout.clearItems();
this.items = [];
variantInfo.twoway.forEach( function ( tw, idx ) { variantInfo.twoway.forEach( function ( tw, idx ) {
this.items[ idx ] = this.createItem( tw.l, tw.t ); this.items[ idx ] = this.createItem( tw.l, tw.t );
this.layout.addItems( [ this.items[ idx ].layout ] ); this.layout.addItems( [ this.items[ idx ].layout ] );
@ -745,7 +746,8 @@ ve.ui.MWLanguageVariantOneWayInspector.prototype.getDefaultVariantInfo = functio
ve.ui.MWLanguageVariantOneWayInspector.prototype.getSetupProcess = function ( data ) { ve.ui.MWLanguageVariantOneWayInspector.prototype.getSetupProcess = function ( data ) {
return ve.ui.MWLanguageVariantOneWayInspector.super.prototype.getSetupProcess.call( this, data ).next( function () { return ve.ui.MWLanguageVariantOneWayInspector.super.prototype.getSetupProcess.call( this, data ).next( function () {
var variantInfo = this.variantNode.getVariantInfo(); var variantInfo = this.variantNode.getVariantInfo();
this.layout.clearItems(); this.items = []; this.layout.clearItems();
this.items = [];
variantInfo.oneway.forEach( function ( ow, idx ) { variantInfo.oneway.forEach( function ( ow, idx ) {
this.items[ idx ] = this.createItem( ow.f, ow.l, ow.t ); this.items[ idx ] = this.createItem( ow.f, ow.l, ow.t );
this.layout.addItems( [ this.items[ idx ].layout ] ); this.layout.addItems( [ this.items[ idx ].layout ] );