wikimedia/mediawiki-extensions-VisualEditor
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor synced 2024-09-27 04:06:51 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge "Check for stopped propagation before showing close dialog"

Browse source
This commit is contained in:
jenkins-bot 2014-12-13 00:52:57 +00:00 committed by Gerrit Code Review
parent 20c53d53bf 9459e4e240
commit e6997350ba
1 changed files with 9 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.js
View file

@ -462,8 +462,16 @@ ve.init.mw.ViewPageTarget.prototype.onSurfaceReady = function () {
* @param {jQuery.Event} e Keydown event
*/
ve.init.mw.ViewPageTarget.prototype.onDocumentKeyDown = function ( e ) {
var target = this;
if ( e.which === OO.ui.Keys.ESCAPE ) {
this.deactivate( false, 'navigate-read' );
setTimeout( function () {
// Listeners should stopPropagation if they handle the escape key, but
// also check they didn't fire after this event, as would be the case if
// they were bound to the document.
if ( !e.isPropagationStopped() ) {
target.deactivate( false, 'navigate-read' );
}
} );
e.preventDefault();
}
};