wikimedia/mediawiki-extensions-VisualEditor
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor synced 2024-12-01 01:16:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

Optimize .selectPartById() to fire less events

Browse source 
There is no point in firing this event when noting changed.
This should reduce flickering and some of the issues described
in I97d77f4.

Change-Id: I7c387889a4a33dac5053cec11a0641d358020b56
This commit is contained in:
Thiemo Kreuz 2021-09-13 13:42:20 +02:00
parent 844606d573
commit e62b3fecbb
1 changed files with 9 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
modules/ve-mw/ui/widgets/ve.ui.MWTransclusionOutlineContainerWidget.js
View file

@ -153,10 +153,17 @@ ve.ui.MWTransclusionOutlineContainerWidget.prototype.addPartWidget = function (
* parameter ids like "part_1/param1". * parameter ids like "part_1/param1".
*/ */
ve.ui.MWTransclusionOutlineContainerWidget.prototype.selectPartById = function ( partId ) { ve.ui.MWTransclusionOutlineContainerWidget.prototype.selectPartById = function ( partId ) {
var changed = false;
for ( var id in this.partWidgets ) { for ( var id in this.partWidgets ) {
this.partWidgets[ id ].setSelected( id === partId ); var selected = id === partId;
if ( this.partWidgets[ id ].isSelected() !== selected ) {
this.partWidgets[ id ].setSelected( selected );
changed = true;
} }
}
if ( changed ) {
this.emit( 'updateOutlineControlButtons', partId ); this.emit( 'updateOutlineControlButtons', partId );
}
}; };
/** /**