From b9376f5990e51f35deeaee534e761dec9611366f Mon Sep 17 00:00:00 2001 From: Thiemo Kreuz Date: Tue, 2 Aug 2022 11:41:07 +0200 Subject: [PATCH] Show "no parameters" message only when there are no parameters The message was also shown when a documented template appears as part of a multi-part transclusion but with zero parameters being used. You see the filters in this case and can click "show all". The message is just wrong in this situation. Bug: T312926 Change-Id: I8d26ceec483e05fd1f69013e506fa1eb4e4c29ed --- .../ui/widgets/ve.ui.MWTransclusionOutlineTemplateWidget.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/modules/ve-mw/ui/widgets/ve.ui.MWTransclusionOutlineTemplateWidget.js b/modules/ve-mw/ui/widgets/ve.ui.MWTransclusionOutlineTemplateWidget.js index b3866db568..238531da58 100644 --- a/modules/ve-mw/ui/widgets/ve.ui.MWTransclusionOutlineTemplateWidget.js +++ b/modules/ve-mw/ui/widgets/ve.ui.MWTransclusionOutlineTemplateWidget.js @@ -39,7 +39,7 @@ ve.ui.MWTransclusionOutlineTemplateWidget = function VeUiMWTransclusionOutlineTe if ( parameterNames.length ) { this.initializeParameterList(); this.parameterList.addItems( parameterNames.map( this.createCheckbox.bind( this ) ) ); - } else { + } else if ( !canFilter ) { this.$noParametersNote = $( '
' ) .text( ve.msg( 'visualeditor-dialog-transclusion-no-template-parameters' ) ) .addClass( 've-ui-mwTransclusionOutlineTemplateWidget-no-template-parameters' );