wikimedia/mediawiki-extensions-VisualEditor
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor synced 2024-11-24 06:24:08 +00:00
Code Issues Packages Projects Releases Wiki Activity

Move gray highlight of template items before blue active rect

Browse source 
Discussed in todays story time. The blue "active" color is mostly a
"reminder with which parameter I interacted last". It's more a
secondary, passive information. In contrast, the gray
highlighting/hover effect that appears when navigating the sidebar
with keyboard or mouse is an active, primary information ("this is
where you are right now"). It's really confusing when the keyboard
navigation indicator disappears behind the blue box.

This patch changes this for both top-level elements as well as
template parameters. The blue text color "shines through" the gray
highlight so we can still see both information.

Bug: T289043
Bug: T311204
Change-Id: Ief6a023d8fde4f6ca0c4b2ea2e831b66e1ea8c83
This commit is contained in:
Thiemo Kreuz 2022-08-10 15:02:48 +02:00 committed by Thiemo Kreuz (WMDE)
parent 5319c49df0
commit e391b5b925
1 changed files with 7 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
modules/ve-mw/ui/styles/widgets/ve.ui.MWTransclusionOutlineWidget.less
View file

@ -79,7 +79,7 @@
background-color: @selected-shading;
&:hover {
background-color: @selected-shading;
background-color: @hover-shading;
color: @selected-text-color;
}
}
@ -148,12 +148,14 @@
color: @on-click-text-color;
}
&.ve-ui-mwTransclusionOutlineParameterWidget-activePage,
&.ve-ui-mwTransclusionOutlineParameterWidget-activePage:hover,
&.ve-ui-mwTransclusionOutlineParameterWidget-activePage.oo-ui-optionWidget-highlighted {
&.ve-ui-mwTransclusionOutlineParameterWidget-activePage {
background-color: @selected-shading;
&,
&.oo-ui-optionWidget-highlighted {
color: @selected-text-color;
}
}
&.oo-ui-optionWidget-highlighted {
background-color: @hover-shading;