wikimedia/mediawiki-extensions-VisualEditor
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor synced 2024-11-15 10:35:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge "ve.ui.MWGalleryDialog: Fix "Alternative text" not being readonly sometimes"

Browse source
This commit is contained in:
jenkins-bot 2022-07-26 20:26:17 +00:00 committed by Gerrit Code Review
parent f7d9da3317 d2f7796744
commit e06cdeadb1
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
modules/ve-mw/ui/dialogs/ve.ui.MWGalleryDialog.js
View file

@ -481,7 +481,7 @@ ve.ui.MWGalleryDialog.prototype.getSetupProcess = function ( data ) {
this.updateMwData( this.originalMwDataNormalized );
}
this.highlightedAltTextInput.setReadOnly( isReadOnly );
this.highlightedAltTextInput.setReadOnly( isReadOnly || this.altTextSameAsCaption.isSelected() );
this.altTextSameAsCaption.setDisabled( isReadOnly );
this.modeDropdown.setDisabled( isReadOnly );
this.widthsInput.setReadOnly( isReadOnly );
@ -808,7 +808,7 @@ ve.ui.MWGalleryDialog.prototype.onHighlightItem = function ( item ) {
this.highlightedCaptionTarget.setDocument( item.captionDocument );
this.highlightedCaptionTarget.setReadOnly( this.isReadOnly() );
this.highlightedAltTextInput.setValue( item.altText );
this.highlightedAltTextInput.setReadOnly( item.altTextSame );
this.highlightedAltTextInput.setReadOnly( this.isReadOnly() || item.altTextSame );
this.altTextSameAsCaption.setSelected( item.altTextSame );
};
@ -837,7 +837,7 @@ ve.ui.MWGalleryDialog.prototype.onModeDropdownChange = function () {
* Handle change event for this.altTextSameAsCaption
*/
ve.ui.MWGalleryDialog.prototype.onAltTextSameAsCaptionChange = function () {
this.highlightedAltTextInput.setReadOnly( this.altTextSameAsCaption.isSelected() );
this.highlightedAltTextInput.setReadOnly( this.isReadOnly() || this.altTextSameAsCaption.isSelected() );
this.updateActions();
};