wikimedia/mediawiki-extensions-VisualEditor
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor synced 2024-11-15 02:23:58 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge "DesktopArticleTarget.init: Pass platform to ve.track directly"

Browse source
This commit is contained in:
jenkins-bot 2018-09-12 14:20:43 +00:00 committed by Gerrit Code Review
parent 7fd850ed24 627128f1ae
commit df253967e1
2 changed files with 14 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.init.js
View file

@ -282,6 +282,10 @@
function trackActivateStart( initData ) { function trackActivateStart( initData ) {
ve.track( 'trace.activate.enter', { mode: initData.mode } ); ve.track( 'trace.activate.enter', { mode: initData.mode } );
// ve.track normally tries to guess the current platform based on
// ve.init.target. We're in a pre-target-loaded state, so have it
// hardcode desktop here.
initData.platform = 'desktop';
ve.track( 'mwedit.init', initData ); ve.track( 'mwedit.init', initData );
mw.libs.ve.activationStart = ve.now(); mw.libs.ve.activationStart = ve.now();
} }

11
modules/ve-mw/init/ve.init.mw.trackSubscriber.js
View file

@ -95,11 +95,20 @@
delete data.mode; delete data.mode;
} }
if ( !data.platform ) {
if ( ve.init && ve.init.target && ve.init.target.constructor.static.platformType ) {
data.platform = ve.init.target.constructor.static.platformType;
} else {
data.platform = 'other';
// TODO: outright abort in this case, once we think we've caught everything
mw.log.warn( 've.init.mw.trackSubscriber: no target available and no platform specified', action );
}
}
event = $.extend( { event = $.extend( {
version: 1, version: 1,
action: action, action: action,
editor: 'visualeditor', editor: 'visualeditor',
platform: ve.init && ve.init.target && ve.init.target.constructor.static.platformType || 'other',
integration: ve.init && ve.init.target && ve.init.target.constructor.static.integrationType || 'page', integration: ve.init && ve.init.target && ve.init.target.constructor.static.integrationType || 'page',
'page.id': mw.config.get( 'wgArticleId' ), 'page.id': mw.config.get( 'wgArticleId' ),
'page.title': mw.config.get( 'wgPageName' ), 'page.title': mw.config.get( 'wgPageName' ),