wikimedia/mediawiki-extensions-VisualEditor
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor synced 2024-11-15 10:35:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix missing Meta+D shortcut on Mac

Browse source 
I also discovered and applied ways to make this code more compact.

Bug: T294905
Change-Id: I1edc2b3b0a77e02bf8e7ac789cabe007c5f5c527
This commit is contained in:
Thiemo Kreuz 2021-11-23 10:38:50 +01:00
parent 53f7b65342
commit ddaa6a18c1
1 changed files with 4 additions and 19 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

23
modules/ve-mw/ui/dialogs/ve.ui.MWTransclusionDialog.js
View file

@ -246,31 +246,16 @@ ve.ui.MWTransclusionDialog.prototype.onReplacePart = function ( removed, added )
this.updateActionSet();
};
/**
* @private
* @param {string} key
* @return {string}
*/
ve.ui.MWTransclusionDialog.prototype.getHotkeyCombo = function ( key ) {
return ( ve.getSystemPlatform() === 'mac' ? 'meta+' : 'ctrl+' ) + 'shift+' + key;
};
/**
* @private
*/
ve.ui.MWTransclusionDialog.prototype.setupHotkeyTriggers = function () {
var context = this;
var meta = ve.getSystemPlatform() === 'mac' ? 'meta+' : 'ctrl+';
this.hotkeyTriggers = {};
this.hotkeyTriggers[ 'ctrl+d' ] = function () {
context.addTemplatePlaceholder();
};
this.hotkeyTriggers[ this.getHotkeyCombo( 'y' ) ] = function () {
context.addContent();
};
this.hotkeyTriggers[ this.getHotkeyCombo( 'd' ) ] = function () {
context.addParameter();
};
this.hotkeyTriggers[ meta + 'd' ] = this.addTemplatePlaceholder.bind( this );
this.hotkeyTriggers[ meta + 'shift+y' ] = this.addContent.bind( this );
this.hotkeyTriggers[ meta + 'shift+d' ] = this.addParameter.bind( this );
};
/**