From d907e973fd40636837c31b5c3cdf57f18b065f47 Mon Sep 17 00:00:00 2001 From: Alex Monk Date: Thu, 1 Sep 2016 02:42:16 +0100 Subject: [PATCH] DesktopWikitextArticleTarget#switchToVisualEditor: Use correct revision ID property So we ensure we send the actual revision ID, not potentially undefined, to the method. If we send undefined, it'll give us an etag for revision number 0... And that will cause issues when we later attempt (in a future editor switch) to pass an etag for revision 0 along with the correct revision. Bug: T143920 Change-Id: I0c27956abdd26ae4f5f1b91010a5eab8ee0354ab --- .../init/targets/ve.init.mw.DesktopWikitextArticleTarget.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/modules/ve-mw/init/targets/ve.init.mw.DesktopWikitextArticleTarget.js b/modules/ve-mw/init/targets/ve.init.mw.DesktopWikitextArticleTarget.js index 1eb08399b2..cf6b5baf83 100644 --- a/modules/ve-mw/init/targets/ve.init.mw.DesktopWikitextArticleTarget.js +++ b/modules/ve-mw/init/targets/ve.init.mw.DesktopWikitextArticleTarget.js @@ -85,7 +85,7 @@ ve.init.mw.DesktopWikitextArticleTarget.prototype.switchToVisualEditor = functio dataPromise = mw.libs.ve.targetLoader.requestParsoidData( this.pageName, - this.requestedRevId, + this.revid, this.constructor.name, this.edited, this.getWikitextFromDocument( this.getSurface().getDom() )