wikimedia/mediawiki-extensions-VisualEditor
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor synced 2024-11-15 10:35:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge "Follow-up 8dfbc5baa: Really don't select unselectable items"

Browse source
This commit is contained in:
jenkins-bot 2013-10-17 17:16:03 +00:00 committed by Gerrit Code Review
parent a3ae0478ed 4721367b61
commit d7b1cd9b4f
1 changed files with 5 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
modules/ve/ui/widgets/ve.ui.SelectWidget.js
View file

@ -109,9 +109,13 @@ ve.ui.SelectWidget.prototype.onMouseDown = function ( e ) {
* @param {jQuery.Event} e Mouse up event
*/
ve.ui.SelectWidget.prototype.onMouseUp = function ( e ) {
var item;
this.pressed = false;
if ( !this.selecting ) {
this.selecting = this.getTargetItem( e );
item = this.getTargetItem( e );
if ( item && item.isSelectable() ) {
this.selecting = item;
}
}
if ( !this.disabled && e.which === 1 && this.selecting ) {
this.selectItem( this.selecting );