From afca7bf0af972cd9eb74373fc19e8bf13934e63c Mon Sep 17 00:00:00 2001 From: Pols12 Date: Wed, 21 Dec 2022 01:59:13 +0100 Subject: [PATCH] =?UTF-8?q?TemplateDialog:=20separate=20=E2=80=9CAdd=20tem?= =?UTF-8?q?plate=E2=80=9D=20messages?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Use distinct messages for section heading, button label and input aria-label, to allow a potentially better localization. Bug: T304121 Change-Id: I3e3b06a035e2f11f5f32face789b934e22916e49 --- extension.json | 1 + i18n/ve-mw/en.json | 1 + i18n/ve-mw/qqq.json | 3 ++- .../ui/widgets/ve.ui.MWTransclusionOutlineControlsWidget.js | 2 +- 4 files changed, 5 insertions(+), 2 deletions(-) diff --git a/extension.json b/extension.json index fe68e045a2..c5f3a7681f 100644 --- a/extension.json +++ b/extension.json @@ -2209,6 +2209,7 @@ "visualeditor-dialog-transclusion-add-param-placeholder", "visualeditor-dialog-transclusion-add-param-save", "visualeditor-dialog-transclusion-add-template", + "visualeditor-dialog-transclusion-add-template-button", "visualeditor-dialog-transclusion-add-template-save", "visualeditor-dialog-transclusion-add-undocumented-param", "visualeditor-dialog-transclusion-add-wikitext", diff --git a/i18n/ve-mw/en.json b/i18n/ve-mw/en.json index aa5aca78f5..386af65788 100644 --- a/i18n/ve-mw/en.json +++ b/i18n/ve-mw/en.json @@ -172,6 +172,7 @@ "visualeditor-dialog-transclusion-add-param-placeholder": "Parameter name", "visualeditor-dialog-transclusion-add-param-save": "Add", "visualeditor-dialog-transclusion-add-template": "Add template", + "visualeditor-dialog-transclusion-add-template-button": "Add template", "visualeditor-dialog-transclusion-add-template-save": "Add", "visualeditor-dialog-transclusion-add-undocumented-param": "Add undocumented parameter", "visualeditor-dialog-transclusion-back-confirmation-prompt": "Go back to search? Your changes will be lost, and this cannot be undone.", diff --git a/i18n/ve-mw/qqq.json b/i18n/ve-mw/qqq.json index bc0c367acc..b229193a11 100644 --- a/i18n/ve-mw/qqq.json +++ b/i18n/ve-mw/qqq.json @@ -192,7 +192,8 @@ "visualeditor-dialog-transclusion-add-param-help": "Help text for new undocumented parameter input field.\n\nParameters:\n* $1 - The title of the template.", "visualeditor-dialog-transclusion-add-param-placeholder": "Placeholder in the input field that adds a new undocumented parameter to a transcluded template.", "visualeditor-dialog-transclusion-add-param-save": "Short label for save button that adds a new undocumented parameter to a transcluded template.", - "visualeditor-dialog-transclusion-add-template": "Heading to add the specified template to the page.", + "visualeditor-dialog-transclusion-add-template": "Heading of the section which allows to add another template to the page.", + "visualeditor-dialog-transclusion-add-template-button": "Extensive label for icon button that allows to add another template to the page. This is a title attribute, so it cannot contain any formatting.", "visualeditor-dialog-transclusion-add-template-save": "Short label for button that adds the specified template to the page.", "visualeditor-dialog-transclusion-add-undocumented-param": "Label for button that adds a new undocumented parameter to a transcluded template.", "visualeditor-dialog-transclusion-back-confirmation-prompt": "Confirmation prompt for abandoning unsaved changes in an insert template dialog.", diff --git a/modules/ve-mw/ui/widgets/ve.ui.MWTransclusionOutlineControlsWidget.js b/modules/ve-mw/ui/widgets/ve.ui.MWTransclusionOutlineControlsWidget.js index 81d1da8f0d..c6323cbb3e 100644 --- a/modules/ve-mw/ui/widgets/ve.ui.MWTransclusionOutlineControlsWidget.js +++ b/modules/ve-mw/ui/widgets/ve.ui.MWTransclusionOutlineControlsWidget.js @@ -23,7 +23,7 @@ ve.ui.MWTransclusionOutlineControlsWidget = function OoUiOutlineControlsWidget() this.addTemplateButton = new OO.ui.ButtonWidget( { framed: false, icon: 'puzzle', - title: ve.msg( 'visualeditor-dialog-transclusion-add-template' ) + title: ve.msg( 'visualeditor-dialog-transclusion-add-template-button' ) } ); this.addWikitextButton = new OO.ui.ButtonWidget( { framed: false,