wikimedia/mediawiki-extensions-VisualEditor
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor synced 2024-09-24 10:48:42 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge "Streamline and harden template paramter search widget behavior"

Browse source
This commit is contained in:
jenkins-bot 2021-08-20 08:35:45 +00:00 committed by Gerrit Code Review
parent c24b91ce5c 45096d1e2f
commit d3e8fe001c
1 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
modules/ve-mw/ui/pages/ve.ui.MWParameterPlaceholderPage.js
View file

@ -105,16 +105,16 @@ ve.ui.MWParameterPlaceholderPage.prototype.setOutlineItem = function () {
}; };
ve.ui.MWParameterPlaceholderPage.prototype.onParameterChoose = function ( name ) { ve.ui.MWParameterPlaceholderPage.prototype.onParameterChoose = function ( name ) {
if ( !name ) { this.addParameterSearch.query.setValue( '' );
if ( !name || this.template.hasParameter( name ) ) {
return; return;
} }
// Note that every parameter is known after it is added // Note that every parameter is known after it is added
var knownBefore = this.template.getSpec().isKnownParameterOrAlias( name ), var knownBefore = this.template.getSpec().isKnownParameterOrAlias( name );
param = new ve.dm.MWParameterModel( this.template, name );
this.addParameterSearch.query.setValue( '' ); this.template.addParameter( new ve.dm.MWParameterModel( this.template, name ) );
this.template.addParameter( param );
ve.track( 'activity.transclusion', { ve.track( 'activity.transclusion', {
action: knownBefore ? 'add-known-parameter' : 'add-unknown-parameter' action: knownBefore ? 'add-known-parameter' : 'add-unknown-parameter'