wikimedia/mediawiki-extensions-VisualEditor
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor synced 2024-11-24 06:24:08 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge "MWSaveDialog: Another check to see if visual diff is still visible"

Browse source
This commit is contained in:
jenkins-bot 2018-02-16 17:15:28 +00:00 committed by Gerrit Code Review
parent e34c085758 33858c6818
commit d21626e7bf
1 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
modules/ve-mw/ui/dialogs/ve.ui.MWSaveDialog.js
View file

@ -719,7 +719,8 @@ ve.ui.MWSaveDialog.prototype.positionDiffElement = function () {
if ( this.panels.getCurrentItem() === this.reviewPanel ) {
setTimeout( function () {
dialog.withoutSizeTransitions( function () {
if ( dialog.diffElement && dialog.isVisible() ) {
// This is delayed, so check the visual diff is still visible
if ( dialog.diffElement && dialog.isVisible() && dialog.reviewModeButtonSelect.findSelectedItem().getData() === 'visual' ) {
dialog.diffElement.positionDescriptions();
dialog.updateSize();
}