From cfc65ae9e5abdc5e5145990e65cae33bc66e67b2 Mon Sep 17 00:00:00 2001 From: Roan Kattouw Date: Wed, 26 Jun 2013 16:35:18 -0700 Subject: [PATCH] Followup to 39fdb135f88b: not everyone has a Mac, so check e.ctrlKey too Bug: 49993 Change-Id: I5245ab19ae16b79d2c562c05b94649a58e04a4fd --- modules/ve/init/mw/targets/ve.init.mw.ViewPageTarget.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/modules/ve/init/mw/targets/ve.init.mw.ViewPageTarget.js b/modules/ve/init/mw/targets/ve.init.mw.ViewPageTarget.js index 6a89659e75..cceba19f2c 100644 --- a/modules/ve/init/mw/targets/ve.init.mw.ViewPageTarget.js +++ b/modules/ve/init/mw/targets/ve.init.mw.ViewPageTarget.js @@ -559,7 +559,7 @@ ve.init.mw.ViewPageTarget.prototype.onEditTabClick = function ( e ) { // Only do our handling if no keys are pressed, mouse button is 1 // (e.g. not middle click or right click) and no modifier keys // (e.g. cmd-click to open in new tab). - if ( ( e.which && e.which !== 1 ) || e.shiftKey || e.altKey || e.metaKey ) { + if ( ( e.which && e.which !== 1 ) || e.shiftKey || e.altKey || e.ctrlKey || e.metaKey ) { return; } this.logEvent( 'Edit', { action: 'edit-link-click' } ); @@ -575,7 +575,7 @@ ve.init.mw.ViewPageTarget.prototype.onEditTabClick = function ( e ) { * @param {jQuery.Event} e Mouse click event */ ve.init.mw.ViewPageTarget.prototype.onEditSectionLinkClick = function ( e ) { - if ( ( e.which && e.which !== 1 ) || e.shiftKey || e.altKey || e.metaKey ) { + if ( ( e.which && e.which !== 1 ) || e.shiftKey || e.altKey || e.ctrlKey || e.metaKey ) { return; } this.logEvent( 'Edit', { action: 'section-edit-link-click' } ); @@ -592,7 +592,7 @@ ve.init.mw.ViewPageTarget.prototype.onEditSectionLinkClick = function ( e ) { * @param {jQuery.Event} e Mouse click event */ ve.init.mw.ViewPageTarget.prototype.onViewTabClick = function ( e ) { - if ( ( e.which && e.which !== 1 ) || e.shiftKey || e.altKey || e.metaKey ) { + if ( ( e.which && e.which !== 1 ) || e.shiftKey || e.altKey || e.ctrlKey || e.metaKey ) { return; } if ( this.active ) {