wikimedia/mediawiki-extensions-VisualEditor
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor synced 2024-11-15 10:35:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

Don't do evil shadowing of mw

Browse source 
Having local variable called mw that shadows the global variable mw
is evil. Rename it to mwAttr.

Change-Id: I87bd3698c73608076424c10fdb0559dfdc3e3045
This commit is contained in:
Catrope 2013-05-26 14:34:47 +02:00
parent 23595970fe
commit cba55b9330
1 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
modules/ve/dm/nodes/ve.dm.MWReferenceNode.js
View file

@ -57,7 +57,7 @@ ve.dm.MWReferenceNode.static.toDataElement = function ( domElements, converter )
}; };
ve.dm.MWReferenceNode.static.toDomElements = function ( dataElement, doc, converter ) { ve.dm.MWReferenceNode.static.toDomElements = function ( dataElement, doc, converter ) {
var itemNodeHtml, mw, var itemNodeHtml, mwAttr,
span = doc.createElement( 'span' ), span = doc.createElement( 'span' ),
itemNodeWrapper = doc.createElement( 'div' ), itemNodeWrapper = doc.createElement( 'div' ),
itemNode = converter.internalList.getItemNode( dataElement.attributes.listIndex ), itemNode = converter.internalList.getItemNode( dataElement.attributes.listIndex ),
@ -72,9 +72,9 @@ ve.dm.MWReferenceNode.static.toDomElements = function ( dataElement, doc, conver
), ),
itemNodeHtml = $( itemNodeWrapper ).html(); itemNodeHtml = $( itemNodeWrapper ).html();
mw = ( dataElement.attributes && ve.copyObject( dataElement.attributes.mw ) ) || {}; mwAttr = ( dataElement.attributes && ve.copyObject( dataElement.attributes.mw ) ) || {};
ve.setProp( mw, 'body', 'html', itemNodeHtml ); ve.setProp( mwAttr, 'body', 'html', itemNodeHtml );
span.setAttribute( 'data-mw', JSON.stringify( mw ) ); span.setAttribute( 'data-mw', JSON.stringify( mwAttr ) );
return [ span ]; return [ span ];
}; };