wikimedia/mediawiki-extensions-VisualEditor
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor synced 2024-09-26 19:56:49 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove duplicate method setUpSurface from ViewPageTarget

Browse source 
Was already implemented in the parent class. Moved setPasteRules() so it
would still get run, everything else had already been moved.

Change-Id: I55ef2622c9eacc8b46bd3487919165bccfc347d5
This commit is contained in:
Roan Kattouw 2013-12-04 14:17:48 -08:00 committed by Catrope
parent 4fe0bc5b80
commit c8608fd7bc
1 changed files with 1 additions and 64 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

65
modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.js
View file

@ -259,6 +259,7 @@ ve.init.mw.ViewPageTarget.prototype.onSurfaceReady = function () {
'documentUpdate': 'checkForWikitextWarning',
'history': 'updateToolbarSaveButtonState'
} );
this.surface.setPasteRules( this.constructor.static.pasteRules );
// Update UI
this.transformPageTitle();
this.changeDocumentTitle();
@ -838,70 +839,6 @@ ve.init.mw.ViewPageTarget.prototype.getSaveOptions = function () {
return options;
};
/**
* Switch to editing mode.
*
* @method
* @param {HTMLDocument} doc HTML DOM to edit
* @param {Function} [callback] Callback to call when done
*/
ve.init.mw.ViewPageTarget.prototype.setUpSurface = function ( doc, callback ) {
var target = this;
setTimeout( function () {
// Build linmod
var store = new ve.dm.IndexValueStore(),
internalList = new ve.dm.InternalList(),
innerWhitespace = new Array( 2 ),
data = ve.dm.converter.getDataFromDom( doc, store, internalList, innerWhitespace );
setTimeout( function () {
// Build DM tree
var dmDoc = new ve.dm.Document( data, doc, undefined, internalList, innerWhitespace );
setTimeout( function () {
// Create ui.Surface (also creates ce.Surface and dm.Surface and builds CE tree)
target.surface = new ve.ui.Surface( dmDoc );
target.surface.$element.addClass( 've-init-mw-viewPageTarget-surface' );
setTimeout( function () {
// Initialize surface
target.surface.getContext().hide();
target.$document = target.surface.$element.find( '.ve-ce-documentNode' );
target.surface.getModel().getDocument().connect( target, {
'transact': 'recordLastTransactionTime'
} );
target.surface.getModel().connect( target, {
'documentUpdate': 'checkForWikitextWarning',
'history': 'updateToolbarSaveButtonState'
} );
target.surface.setPasteRules( target.constructor.static.pasteRules );
target.$element.append( target.surface.$element );
target.setUpToolbar();
target.transformPageTitle();
target.changeDocumentTitle();
// Update UI
target.hidePageContent();
target.hideSpinner();
target.active = true;
target.$document.attr( {
'lang': mw.config.get( 'wgVisualEditor' ).pageLanguageCode,
'dir': mw.config.get( 'wgVisualEditor' ).pageLanguageDir
} );
// Add appropriately mw-content-ltr or mw-content-rtl class
target.surface.view.$element.addClass(
'mw-content-' + mw.config.get( 'wgVisualEditor' ).pageLanguageDir
);
// Now that the surface is attached to the document and ready,
// let it initialize itself
target.surface.initialize();
setTimeout( callback );
} );
} );
} );
} );
};
/**
* Fire off the sanity check. Must be called before the surface is activated.
*