wikimedia/mediawiki-extensions-VisualEditor
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor synced 2024-11-28 16:20:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

Don't use jQuery show() or toggle()

Browse source 
These set display explicitly to block, which overrides the CSS
style of display: table-caption.

Change-Id: Id987d6e8da9c875a120a4f07560fa8a97bef10b6
This commit is contained in:
Ed Sanders 2014-06-13 17:37:14 +01:00
parent a1984590b3
commit c761a20cef
1 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
modules/ve-mw/ce/nodes/ve.ce.MWBlockImageNode.js
View file

@ -139,7 +139,8 @@ ve.ce.MWBlockImageNode.prototype.updateCaption = function () {
}
}
if ( this.$caption ) {
this.$caption.toggle( this.captionVisible );
// Don't use show() as it sets display to block, overriding the stylesheet.
this.$caption.css( 'display', this.captionVisible ? '' : 'none' );
}
};