wikimedia/mediawiki-extensions-VisualEditor
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor synced 2024-11-15 10:35:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge "ve.ui.MWGalleryDialog: Handle galleries with 0 items"

Browse source
This commit is contained in:
jenkins-bot 2018-02-22 00:31:29 +00:00 committed by Gerrit Code Review
parent 180eb91f3f 3d422bac2a
commit c5cc11079b
1 changed files with 14 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

26
modules/ve-mw/ui/dialogs/ve.ui.MWGalleryDialog.js
View file

@ -553,27 +553,19 @@ ve.ui.MWGalleryDialog.prototype.onSearchResultsChoose = function ( item ) {
* Handle click event for the remove button
*/
ve.ui.MWGalleryDialog.prototype.onRemoveItem = function () {
// Remove the highlighted item
this.galleryGroup.removeItems( [ this.highlightedItem ] );
// Show the search panel if the gallery is now empty...
if ( this.galleryGroup.items.length === 0 ) {
this.toggleEmptyGalleryMessage( true );
this.showSearchPanelButton.toggle( false );
this.toggleSearchPanel( true );
// ...Otherwise highlight the first item in the gallery
} else {
// Highlight another item, or show the search panel if the gallery is now empty
this.onHighlightItem();
}
this.updateActions();
};
/**
* Handle clicking on an image in the menu
*
* @param {ve.ui.MWGalleryItemWidget} item The item that was clicked on
* @param {ve.ui.MWGalleryItemWidget} [item] The item that was clicked on
*/
ve.ui.MWGalleryDialog.prototype.onHighlightItem = function ( item ) {
var title;
@ -586,8 +578,18 @@ ve.ui.MWGalleryDialog.prototype.onHighlightItem = function ( item ) {
// Show edit panel
this.toggleSearchPanel( false );
// Highlight new item
// Highlight new item.
// If no item was given, highlight the first item in the gallery.
item = item || this.galleryGroup.items[ 0 ];
if ( !item ) {
// Show the search panel if the gallery is empty
this.toggleEmptyGalleryMessage( true );
this.showSearchPanelButton.toggle( false );
this.toggleSearchPanel( true );
return;
}
item.toggleHighlighted( true );
this.highlightedItem = item;