wikimedia/mediawiki-extensions-VisualEditor
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor synced 2024-11-28 00:00:49 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge "Remove unused getCurrentPageName method from two-pane layout"

Browse source
This commit is contained in:
jenkins-bot 2022-07-20 17:51:09 +00:00 committed by Gerrit Code Review
parent ea2cc5e199 2e2a8257bd
commit c2d867d348
1 changed files with 2 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
modules/ve-mw/ui/layouts/ve.ui.MWTwoPaneTransclusionDialogLayout.js
View file

@ -117,15 +117,14 @@ ve.ui.MWTwoPaneTransclusionDialogLayout.prototype.onStackLayoutFocus = function
/** /**
* Focus the input field for the current page. * Focus the input field for the current page.
* *
* If no page is selected, the first selectable page will be selected.
* If the focus is already in an element on the current page, nothing will happen. * If the focus is already in an element on the current page, nothing will happen.
*/ */
ve.ui.MWTwoPaneTransclusionDialogLayout.prototype.focus = function () { ve.ui.MWTwoPaneTransclusionDialogLayout.prototype.focus = function () {
var page = this.pages[ this.currentPageName ]; var page = this.pages[ this.currentPageName ];
if ( !page ) { if ( !page ) {
return; return;
} }
// Only change the focus if it's visible and is not already the current page // Only change the focus if it's visible and is not already the current page
if ( page.$element[ 0 ].offsetParent !== null && if ( page.$element[ 0 ].offsetParent !== null &&
!OO.ui.contains( page.$element[ 0 ], this.getElementDocument().activeElement, true ) !OO.ui.contains( page.$element[ 0 ], this.getElementDocument().activeElement, true )
@ -226,15 +225,7 @@ ve.ui.MWTwoPaneTransclusionDialogLayout.prototype.getPage = function ( name ) {
* @return {OO.ui.PageLayout|undefined} Current page, if found * @return {OO.ui.PageLayout|undefined} Current page, if found
*/ */
ve.ui.MWTwoPaneTransclusionDialogLayout.prototype.getCurrentPage = function () { ve.ui.MWTwoPaneTransclusionDialogLayout.prototype.getCurrentPage = function () {
var name = this.getCurrentPageName(); return this.pages[ this.currentPageName ];
return name ? this.getPage( name ) : undefined;
};
/**
* @return {string|null} Symbolic name of the current page
*/
ve.ui.MWTwoPaneTransclusionDialogLayout.prototype.getCurrentPageName = function () {
return this.currentPageName;
}; };
/** /**