From 8c3dc0887da322a654fc5c4db7e87a6d509f5d0b Mon Sep 17 00:00:00 2001 From: Alex Monk Date: Fri, 20 May 2016 02:36:25 +0100 Subject: [PATCH] Don't show tab preference dialog again if it's already been shown Bug: T135534 Change-Id: Ifecac607acccc0e18e61b07e8456566d4671aa1b --- .../ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.init.js | 1 + modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.js | 1 + 2 files changed, 2 insertions(+) diff --git a/modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.init.js b/modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.init.js index f339c6b2f0..53cae13670 100644 --- a/modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.init.js +++ b/modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.init.js @@ -823,6 +823,7 @@ // Duplicate of this code in ve.init.mw.DesktopArticleTarget.js if ( $( '#ca-edit' ).hasClass( 'visualeditor-showtabdialog' ) ) { + $( '#ca-edit' ).removeClass( 'visualeditor-showtabdialog' ); // Set up a temporary window manager windowManager = new OO.ui.WindowManager(); $( 'body' ).append( windowManager.$element ); diff --git a/modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.js b/modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.js index 1debd0bd44..5a4e02390b 100644 --- a/modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.js +++ b/modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.js @@ -266,6 +266,7 @@ ve.init.mw.DesktopArticleTarget.prototype.loadSuccess = function ( response ) { // Duplicate of this code in ve.init.mw.DesktopArticleTarget.init.js if ( $( '#ca-edit' ).hasClass( 'visualeditor-showtabdialog' ) ) { + $( '#ca-edit' ).removeClass( 'visualeditor-showtabdialog' ); // Set up a temporary window manager windowManager = new OO.ui.WindowManager(); $( 'body' ).append( windowManager.$element );