From bf22d07d2b5e76ffcc0f37cf17847bfbfda3295e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bartosz=20Dziewo=C5=84ski?= Date: Thu, 14 Nov 2024 22:38:00 +0100 Subject: [PATCH] Fix Phan error related to showPendingTakeover() Caused by type hints added in MediaWiki core in I3e0df790ff9db2fa630f82408a7254a359fe61ca. Change-Id: I45d0906c11d9e66801dfedd54e6018e90ef027c4 --- includes/Hooks.php | 1 + 1 file changed, 1 insertion(+) diff --git a/includes/Hooks.php b/includes/Hooks.php index 955d42711d..c8561c24a1 100644 --- a/includes/Hooks.php +++ b/includes/Hooks.php @@ -410,6 +410,7 @@ class Hooks implements $out = $article->getContext()->getOutput(); $titleMsg = $title->exists() ? 'editing' : 'creating'; $out->setPageTitleMsg( wfMessage( $titleMsg, $title->getPrefixedText() ) ); + // @phan-suppress-next-line PhanTypeMismatchArgumentNullable Only null for invalid URL, shouldn't happen $out->showPendingTakeover( $url, 'visualeditor-toload', $urlUtils->expand( $url ) ); $out->setRevisionId( $req->getInt( 'oldid', $article->getRevIdFetched() ) );