wikimedia/mediawiki-extensions-VisualEditor
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor synced 2024-11-28 16:20:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge "Fix annotation object creation in SurfaceFragment"

Browse source
This commit is contained in:
Catrope 2012-10-26 17:53:10 +00:00 committed by Gerrit Code Review
parent 52f1aac90a 8c3802308e
commit bc8b042e5f
2 changed files with 4 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
modules/ve/dm/ve.dm.Annotation.js
View file

@ -19,6 +19,8 @@
* this.data by overriding getAnnotationData(). Subclasses can read from this.data but must not
* write to it directly.
*
* TODO: Make this constructor optionally accept a data object instead of an element.
*
* @class
* @abstract
* @constructor

3
modules/ve/dm/ve.dm.SurfaceFragment.js
View file

@ -358,7 +358,8 @@ ve.dm.SurfaceFragment.prototype.annotateContent = function ( method, type, data
return this;
}
var tx,
annotation = { 'type': type };
annotation = ve.dm.annotationFactory.create( type );
// HACK: This seems wrong, the way we create annotations should be refactored
if ( data ) {
annotation.data = data;
}