wikimedia/mediawiki-extensions-VisualEditor
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor synced 2024-09-25 11:16:51 +00:00
Code Issues Packages Projects Releases Wiki Activity

Frame initialization exceptions

Browse source 
Don't call initialize inside the try-catch, it ends up sending exceptions thrown inside that method to /dev/null.

Change-Id: I8e0945f35c639ec156ee9a163b86fddfaed0ea7b
This commit is contained in:
Trevor Parscal 2013-04-18 16:52:03 -07:00
parent 93cb630aed
commit bb232a0ee7
1 changed files with 10 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
modules/ve/ui/ve.ui.Frame.js
View file

@ -95,13 +95,16 @@ ve.ui.Frame.prototype.onLoad = function () {
try { try {
// MAGIC: only accessible when the stylesheet is loaded // MAGIC: only accessible when the stylesheet is loaded
rules = style.sheet.cssRules; rules = style.sheet.cssRules;
// If that didn't throw an exception, we're done loading } catch ( e ) {
clearInterval( interval ); // Try again in 10ms
// Protect against IE running interval one extra time after clearing return;
if ( !this.initialized ) { }
initialize(); // If that didn't throw an exception, we're done loading
} clearInterval( interval );
} catch ( e ) { } // Protect against IE running interval one extra time after clearing
if ( !this.initialized ) {
initialize();
}
}, this ), 10 ); }, this ), 10 );
// Properties // Properties