wikimedia/mediawiki-extensions-VisualEditor
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor synced 2024-09-25 19:26:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

ve.ui.MWSaveDialog: Improve handling of links in edit summary preview

Browse source 
* Pass the page title, so that links to section point to the current
  page rather than "API"
* Make all links open in a new window, instead of producing a warning
  about losing your changes

Bug: T208978
Change-Id: Ia1924e1af644ee41ebcaa1da40ca004cb72dcdaf
This commit is contained in:
Bartosz Dziewoński 2018-11-27 02:38:37 +01:00
parent b34e625f4c
commit b983538038
1 changed files with 7 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
modules/ve-mw/ui/dialogs/ve.ui.MWSaveDialog.js
View file

@ -392,13 +392,18 @@ ve.ui.MWSaveDialog.prototype.swapPanel = function ( panel, noFocus ) {
.addClass( 'mw-ajax-loader' );
this.editSummaryXhr = ve.init.target.getContentApi().post( {
action: 'parse',
title: ve.init.target.getPageName(),
prop: '',
summary: currentEditSummaryWikitext
} ).done( function ( result ) {
if ( result.parse.parsedsummary[ '*' ] === '' ) {
dialog.$reviewEditSummary.parent().addClass( 'oo-ui-element-hidden' );
} else {
// Intentionally treated as HTML
dialog.$reviewEditSummary.html( ve.msg( 'parentheses', result.parse.parsedsummary[ '*' ] ) );
dialog.$reviewEditSummary
// Intentionally treated as HTML
.html( ve.msg( 'parentheses', result.parse.parsedsummary[ '*' ] ) )
// Make any links open in a new window
.find( 'a' ).prop( 'target', '_blank' ).attr( 'rel', 'noopener' );
}
} ).fail( function () {
dialog.$reviewEditSummary.parent().addClass( 'oo-ui-element-hidden' );