wikimedia/mediawiki-extensions-VisualEditor
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor synced 2024-09-25 19:26:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove explicit setting of ce=false on FocusableNodes

Browse source 
FocusableNode already sets ce=false so this is redundant.

Change-Id: I4432dd0a5e5dff3f8e909f2d7c1912f3d69e1b70
This commit is contained in:
Ed Sanders 2015-08-31 17:26:49 +01:00 committed by Jforrester
parent 8502d3ea05
commit b9183540ef
2 changed files with 3 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
modules/ve-mw/ce/nodes/ve.ce.MWMagicLinkNode.js
View file

@ -23,14 +23,10 @@ ve.ce.MWMagicLinkNode = function VeCeMWMagicLinkNode( model, config ) {
ve.ce.FocusableNode.call( this );
// DOM changes
this.$element
.addClass( 've-ce-mwMagicLinkNode' )
// Need CE=false to prevent selection issues
.prop( 'contentEditable', 'false' );
this.$element.addClass( 've-ce-mwMagicLinkNode' );
// Add link
this.$link = $( '<a>' )
.appendTo( this.$element );
this.$link = $( '<a>' ).appendTo( this.$element );
// Events
this.model.connect( this, { update: 'onUpdate' } );

5
modules/ve-mw/ce/nodes/ve.ce.MWNumberedExternalLinkNode.js
View file

@ -23,10 +23,7 @@ ve.ce.MWNumberedExternalLinkNode = function VeCeMWNumberedExternalLinkNode( mode
ve.ce.FocusableNode.call( this );
// DOM changes
this.$element
.addClass( 've-ce-mwNumberedExternalLinkNode' )
// Need CE=false to prevent selection issues
.prop( 'contentEditable', 'false' );
this.$element.addClass( 've-ce-mwNumberedExternalLinkNode' );
// Add link
this.$link = $( '<a>' )