From b69c89e37832bc2fe9d6c7d8502dce4f2e580e64 Mon Sep 17 00:00:00 2001 From: Esther Akinloose Date: Wed, 29 Jun 2022 15:00:54 +0100 Subject: [PATCH] selenium: Enable all tests EditPage.activationComplete() was flaky. We have replaced it with EditPage.toolbar.waitForDisplayed(). We have run all the tests 100 times in a row in CI and it works fine. Bug: T310772 Change-Id: I321b4114ca03ebd02a79d8bd3863ea0e68494dc2 --- tests/selenium/specs/content_editable.js | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/tests/selenium/specs/content_editable.js b/tests/selenium/specs/content_editable.js index ef4e1e0eae..d75ae40311 100644 --- a/tests/selenium/specs/content_editable.js +++ b/tests/selenium/specs/content_editable.js @@ -8,27 +8,26 @@ describe( 'Content Editable', function () { let name, content; - // See T310772 - it.skip( 'should load when an url is opened @daily', async function () { + it( 'should load when an url is opened @daily', async function () { content = Util.getTestString(); name = Util.getTestString(); await browser.deleteAllCookies(); await LoginPage.loginAdmin(); await EditPage.openForEditing( name ); - await EditPage.activationComplete(); + await EditPage.toolbar.waitForDisplayed( { timeout: 20000 } ); assert( await EditPage.toolbar.isDisplayed() ); } ); - it.skip( 'should be editable', async function () { + it( 'should be editable', async function () { content = Util.getTestString(); name = Util.getTestString(); await browser.deleteAllCookies(); await LoginPage.loginAdmin(); await EditPage.openForEditing( name ); - await EditPage.activationComplete(); + await EditPage.toolbar.waitForDisplayed( { timeout: 20000 } ); await EditPage.veRootNode.setValue( content ); @@ -40,14 +39,14 @@ describe( 'Content Editable', function () { await browser.reloadSession(); } ); - it.skip( 'should save an edit', async function () { + it( 'should save an edit', async function () { content = Util.getTestString(); name = Util.getTestString(); await browser.deleteAllCookies(); await LoginPage.loginAdmin(); await EditPage.openForEditing( name ); - await EditPage.activationComplete(); + await EditPage.toolbar.waitForDisplayed( { timeout: 20000 } ); await EditPage.veRootNode.setValue( content ); await EditPage.savePageDots.click();