From 13a7a4c5f9b5aa1fae8f22aba1d894e399f304ea Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bartosz=20Dziewo=C5=84ski?= Date: Tue, 10 May 2016 19:24:20 +0200 Subject: [PATCH] ve.ui.MWParameterPage: Remove non-working 'focus' handler This element is a plain `
` with no tabindex, and therefore can't be focussed. jQuery 'focus' events don't bubble, either, which would otherwise allow focus events on children to fire this handler. Change-Id: I68cb7d3bac143565c0a1bdb988312233b2d13ccd --- modules/ve-mw/ui/pages/ve.ui.MWParameterPage.js | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/modules/ve-mw/ui/pages/ve.ui.MWParameterPage.js b/modules/ve-mw/ui/pages/ve.ui.MWParameterPage.js index d9c403a0c8..caf29fba2f 100644 --- a/modules/ve-mw/ui/pages/ve.ui.MWParameterPage.js +++ b/modules/ve-mw/ui/pages/ve.ui.MWParameterPage.js @@ -105,8 +105,7 @@ ve.ui.MWParameterPage = function VeUiMWParameterPage( parameter, name, config ) ); this.$more .addClass( 've-ui-mwParameterPage-more' ) - .append( this.addButton.$element ) - .focus( this.onAddButtonFocus.bind( this ) ); + .append( this.addButton.$element ); this.$element .addClass( 've-ui-mwParameterPage' ) .append( this.$info, this.$field, this.$actions, this.$more );