wikimedia/mediawiki-extensions-VisualEditor
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor synced 2024-11-30 17:14:42 +00:00
Code Issues Packages Projects Releases Wiki Activity

ParameterWidget: Connect to Search results widget 'choose' events

Browse source 
Instead of using the removed 'select' event submission on SearchWidget.

Rename event fired by MWParameterSearchWidget to reflect the new re-
emissioned choose event.

Follow up: I7fa97f208da0b3b185f1b09b87fef9c9afaee2f1

Bug: T106696
Change-Id: I1d954a7243649d7834373537d70bfadf68f52c9d
This commit is contained in:
Florian 2015-07-24 20:05:22 +02:00
parent cb1cb6bdb5
commit b390a32fda
2 changed files with 8 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
modules/ve-mw/ui/pages/ve.ui.MWParameterPlaceholderPage.js
View file

@ -33,7 +33,7 @@ ve.ui.MWParameterPlaceholderPage = function VeUiMWParameterPlaceholderPage( para
showAll: !!config.expandedParamList
} )
.connect( this, {
select: 'onParameterSelect',
choose: 'onParameterChoose',
showAll: 'onParameterShowAll'
} );
@ -91,7 +91,7 @@ ve.ui.MWParameterPlaceholderPage.prototype.setOutlineItem = function ( outlineIt
}
};
ve.ui.MWParameterPlaceholderPage.prototype.onParameterSelect = function ( name ) {
ve.ui.MWParameterPlaceholderPage.prototype.onParameterChoose = function ( name ) {
var param;
if ( name ) {

11
modules/ve-mw/ui/widgets/ve.ui.MWParameterSearchWidget.js
View file

@ -34,6 +34,7 @@ ve.ui.MWParameterSearchWidget = function VeUiMWParameterSearchWidget( template,
// Events
this.template.connect( this, { add: 'buildIndex', remove: 'buildIndex' } );
this.getResults().connect( this, { choose: 'onSearchResultsChoose' } );
// Initialization
this.$element.addClass( 've-ui-mwParameterSearchWidget' );
@ -47,7 +48,7 @@ OO.inheritClass( ve.ui.MWParameterSearchWidget, OO.ui.SearchWidget );
/* Events */
/**
* @event select
* @event choose
* @param {string|null} name Parameter name or null if no item is selected
*/
@ -68,16 +69,16 @@ ve.ui.MWParameterSearchWidget.prototype.onQueryChange = function () {
};
/**
* Handle select widget select events.
* Handle SelectWidget choose events.
*
* @method
* @param {OO.ui.OptionWidget} item Selected item
* @fires select
* @fires choose
* @fires showAll
*/
ve.ui.MWParameterSearchWidget.prototype.onResultsSelect = function ( item ) {
ve.ui.MWParameterSearchWidget.prototype.onSearchResultsChoose = function ( item ) {
if ( item instanceof ve.ui.MWParameterResultWidget ) {
this.emit( 'select', item.getData().name );
this.emit( 'choose', item.getData().name );
} else if ( item instanceof ve.ui.MWMoreParametersResultWidget ) {
this.showAll = true;
this.addResults();