wikimedia/mediawiki-extensions-VisualEditor
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor synced 2024-09-25 03:08:42 +00:00
Code Issues Packages Projects Releases Wiki Activity

Revert "Show <newarticletext> as surface placeholder, not an edit notice"

Browse source 
This reverts commit 5ac5c7a05b.

Bug: T104227
Change-Id: Id86dd228c2c671758acc6d2d3314c92da8917472
This commit is contained in:
Esanders 2015-07-02 10:25:19 +00:00
parent 5ac5c7a05b
commit b2ff7aaa17
2 changed files with 2 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
ApiVisualEditor.php
View file

@ -369,9 +369,8 @@ class ApiVisualEditor extends ApiBase {
}
// New page notices
$placeholder = null;
if ( !$title->exists() ) {
$placeholder = $this->msg(
$notices[] = $this->msg(
$user->isLoggedIn() ? 'newarticletext' : 'newarticletextanon',
wfExpandUrl( Skin::makeInternalOrExternalUrl(
$this->msg( 'helppage' )->inContentLanguage()->text()
@ -520,7 +519,6 @@ class ApiVisualEditor extends ApiBase {
$result = array(
'result' => 'success',
'notices' => $notices,
'placeholder' => $placeholder,
'checkboxes' => $checkboxes,
'links' => $links,
'protectedClasses' => implode( ' ', $protectedClasses ),

3
modules/ve-mw/init/ve.init.mw.Target.js
View file

@ -313,7 +313,6 @@ ve.init.mw.Target.onLoad = function ( response ) {
this.constructor.static.fixBase( this.doc );
this.remoteNotices = ve.getObjectValues( data.notices );
this.placeholderText = $( $.parseHTML( data.placeholder ) ).text();
this.protectedClasses = data.protectedClasses;
this.$checkboxes = $( ve.getObjectValues( data.checkboxes ).join( '' ) );
// Populate checkboxes with default values for minor and watch
@ -1273,7 +1272,7 @@ ve.init.mw.Target.prototype.setupSurface = function ( doc, callback ) {
// Create ui.Surface (also creates ce.Surface and dm.Surface and builds CE tree)
ve.track( 'trace.createSurface.enter' );
var surface = target.addSurface( dmDoc, { placeholder: target.placeholderText } ),
var surface = target.addSurface( dmDoc ),
surfaceView = surface.getView(),
$documentNode = surfaceView.getDocument().getDocumentNode().$element;
ve.track( 'trace.createSurface.exit' );