From ed0105b5a188943019f99c46998cc72751f3e473 Mon Sep 17 00:00:00 2001 From: Ed Sanders Date: Fri, 5 Apr 2019 14:43:27 +0100 Subject: [PATCH] EditSummaryWidget: Disable pending animation Animation shows breifly on every keystroke, even though only one server request is made, as the promises always yield to a browser animation frame. A pending animation isn't really required for autocomplete as the results are only optional suggestions. Change-Id: Ifa257592b10d84dccfa3e0c819c1edf1f7ef9cfa --- modules/ve-mw/ui/widgets/ve.ui.MWEditSummaryWidget.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/modules/ve-mw/ui/widgets/ve.ui.MWEditSummaryWidget.js b/modules/ve-mw/ui/widgets/ve.ui.MWEditSummaryWidget.js index 53a484119b..a7b41742f0 100644 --- a/modules/ve-mw/ui/widgets/ve.ui.MWEditSummaryWidget.js +++ b/modules/ve-mw/ui/widgets/ve.ui.MWEditSummaryWidget.js @@ -19,8 +19,9 @@ ve.ui.MWEditSummaryWidget = function VeUiMWEditSummaryWidget( config ) { config = config || {}; + // HACK: Disable pending animation. Should be made an upstream option (T220204) // Parent method - ve.ui.MWEditSummaryWidget.super.apply( this, arguments ); + ve.ui.MWEditSummaryWidget.super.call( this, ve.extendObject( { $pending: $( [] ) }, config ) ); // Mixin method OO.ui.mixin.LookupElement.call( this, ve.extendObject( { allowSuggestionsWhenEmpty: false }, config ) );